logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominik Psenner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4NET-473) Option for file extension in SmtpPickupDirAppender
Date Sat, 31 Oct 2015 09:25:27 GMT

    [ https://issues.apache.org/jira/browse/LOG4NET-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983913#comment-14983913
] 

Dominik Psenner commented on LOG4NET-473:
-----------------------------------------

I've just tried to apply your patch and there are issues:

Your patch does not apply neatly to current trunk, please make your patches such that they
are based on the trunk root path and apply to trunk.

The more concerning issue is that even though you have added properties and attributes, they
are not used anywhere. The patch doesn't add anything that will use that file extension if
it is provided, does it?

Cheers

> Option for file extension in SmtpPickupDirAppender
> --------------------------------------------------
>
>                 Key: LOG4NET-473
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-473
>             Project: Log4net
>          Issue Type: New Feature
>    Affects Versions: 1.2.13
>            Reporter: Albin Sunnanbo
>         Attachments: SmtpPickupDirAppender-fileextension.patch
>
>
> Especially on Windows file extensions are very handy, if you give the output files the
`eml` extension you can just double click the file to open the mail in outlook.
> I have added a `FileExtension` option to the `SmtpPickupDirAppender` that can be used
to specify a file extension for the generated files.
> Although a default value of `eml` would be nice I have preserved backwards compatibility
of no file extension by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message