logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michel Emond (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LOG4NET-465) Rolling log files get overwritten when IIS is restarted
Date Thu, 25 Jun 2015 14:31:04 GMT

    [ https://issues.apache.org/jira/browse/LOG4NET-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601262#comment-14601262
] 

Michel Emond edited comment on LOG4NET-465 at 6/25/15 2:30 PM:
---------------------------------------------------------------

I had these lines removed for the following reason: In DetermineCurSizeRollBackups(), fullPath
is fixed with the date pattern (by the lines added in my fix) and then fed to GetExistingFiles().
The result of GetExistingFiles() is then passed to InitializeRollBackups() and then to InitializeFromOneFile()
(i.e. where the lines are removed). At this point, every file name being handled already matches
the date pattern so there's no need for an additional check.

Sure, no problem, that's what code reviews are for!


was (Author: memond):
I had these lines removed for the following reason: In DetermineCurSizeRollBackups(), fullPath
is fixed with the date pattern and then fed to GetExistingFiles(). The result of GetExistingFiles()
is then passed to InitializeRollBackups() and then to InitializeFromOneFile() (i.e. where
the lines are removed). At this point, every file name being handled already matches the date
pattern so there's no need for an additional check.

Sure, no problem, that's what code reviews are for!

> Rolling log files get overwritten when IIS is restarted
> -------------------------------------------------------
>
>                 Key: LOG4NET-465
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-465
>             Project: Log4net
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 1.2.13
>         Environment: asp.net 4.0
>            Reporter: Michel Emond
>         Attachments: RollingFileAppender.diff, config.xml
>
>
> This is the issue described in LOG4NET-378
> h2. Reproduction steps
> # Setup a web application using the settings from the attached config.xml file
> # Notice the rolling style set to Composite
> # Start and use the application
> # The log files pile up in the folder
> # Restart IIS
> # Keep using the application
> Expected result
> - The rolling continues on or after the last file
> Actual result
> - The rolling restarts at index 1 and overwrites the existing files
> h2. Solution
> See the attached files:
> - config.xml
> - patch with a fix proposal
> The original bug fix addresses the issue in the InitializeFromOneFile() method.
> However, the GetWildcardPatternForFile() method also needs the baseFileName to be adjusted
with the datePattern so the proper files are searched.
> I placed a file path fix in the DetermineCurSizeRollBackups() method, so it's then passed
down to the two other methods and everyone gets happy.
> Here's a calling stack sample:
> {code}
> DetermineCurSizeRollBackups()
> |
> +--GetExistingFiles()
> |  +--GetWildcardPatternForFile()
> |
> +--InitializeRollBackups()
>    +--InitializeFromOneFile()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message