logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: Sysinternals Process Monitor appender
Date Thu, 06 Mar 2014 12:31:10 GMT
On 2014-03-06, Justin Dearing wrote:

> On Thu, Mar 6, 2014 at 5:07 AM, Stefan Bodewig <bodewig@apache.org> wrote:

>>> If I were to make an appender without the dependency on Wintellect's C++
>>> code, could that be added to the log4net built in Appenders?

>> Would it have any other external dependency?  I don't think we'd want to
>> add any new dependencies to log4net itself.

> There are no dependencies other than the .NET framework and PInvoke..
> Everything happens trough Win32 FileIO. Here is a simple LINQpad example of
> me writing to procmon.

> https://github.com/zippy1981/ProcMon.LINQpad

I'll have a look.

>> Other than that we'd likely need to get some legal issues clear - it is
>> your code and your code alone and you want to grant ot to the ASF -

> I wrote all the code in that LINQpad myself. I used Wintellect's managed
> version and pinvoke.net as references. John from Wintellect has said he is
> ok with me including me code in log4net, but  is willing to sign something
> if someone felt it was necessary. I'm personally willing to keep copyright,
> assign copyright, or hold joint copyright, as per whatever ASF wants.z

I don't think we need any papers signed by John.  The ASF doesn't do
copyright assignement, you'd keep the copyright and grant a license
(using the Apache License in reverse direction) to the ASF.  The ASF
only copyrights the "joined" work of the log4net distribution.

If you'd open a JIRA ticket and attach a patch that is generally enough
to indicate you want to contribute your code.  This is via section 5 of
http://www.apache.org/licenses/LICENSE-2.0

Doing away with legaleese.

> Its not a lot of code to write, so I'd rather debate a patch than code I
> will theoretically write. You guys use SVN. Should I just email an actual
> patch to the list? If I were to import the svn repo as a git repo on
> github, could you guys generate a patch from that to allow for back and
> forth feedback? Is there a formal vote?

First open a JIRA ticket as our point of reference.  We can work with
patches attached to the ticket or with pull requests, whatever suits you
better.

There is a github mirror of the log4net repo at
https://github.com/apache/log4net and I think we've taken all setup
steps necessary for using some Apache side integration of github PRs
with Apache JIRA tickets and mailing lists.  IIUC you use the JIRA
ticket number (LOG4NET-000) inside you PR comment and it will
automatically be linked with the ticket[1] - but you'd be the first
person trying this out for log4net :-)

Stefan

[1] http://blogs.apache.org/infra/entry/improved_integration_between_apache_and


Mime
View raw message