logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Changed some defines
Date Mon, 04 Nov 2013 05:31:29 GMT
Hi all,

I have removed all defines that correspond to frameworks trunk no longer
builds and also dropped the *_2_0 symbols as they are the default now -
on that way I've removed a few chunks of 1.x specific code.

For the Compact Framework 2.0 build I'll ask Dustin Jones, the reporter
of LOG4NET-399 to verify I haven't broken things.

Also I changed NET_3_5 and NET_4_0 to FRAMEWORK_3_5 and FRAMEWORK_4_0,
the idea is that we reuse those symbols for Mono as well and make it
switch on API versions rather than implementations.  Does that make
sense?

Unfortunately I somehow missed the introduction of NET_3_5 which was not
part of the build setup.  This means the 3.5 builds of 1.2.12 do no
contain the ILog extension methods.  In new trunk builds they now do,
which also means the 3.5 version is now really different from the 2.0
one.

Finally I'm thinking about defining FRAMEWORK_3_5 for the net-4.0 build
as well so 

#if FRAMEWORK_3_5 || FRAMEWORK_4_0

could be collapsed to 

#if FRAMEWORK_3_5

and each conditional could just use the one version the required feature
has first been added in.

Stefan

Mime
View raw message