logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominik Psenner" <dpsen...@gmail.com>
Subject AW: Tagging 1.2.12
Date Thu, 08 Aug 2013 11:59:34 GMT
>-----Urspr√ľngliche Nachricht-----
>Von: Stefan Bodewig [mailto:bodewig@apache.org]
>Gesendet: Donnerstag, 8. August 2013 13:37
>An: Log4NET Dev
>Betreff: Re: Tagging 1.2.12
>
>On 2013-08-08, Dominik Psenner wrote:
>
>> There is:
>
>> I've just run the tests and the RemotingAppenderTests seem to fail. Until
>> now I don't know why. Ideas?
>
>Line 103?  Yes, fails for me as well.  I'll look into it later, can't
>promise to come up with an idea, though :-)
>
>I get two more test errors in PatternLayoutTest and
>DynamciPatternLayoutTest - TestStacktracePattern in both cases.  Some
>internal changes to the .NET framework are leaking into the test
>assertions and it now fails because it expects InvokeMethod but gets
>_InvokeMethodFast - we'd better make the test more robust.

Three things I've done there:

* I fixed XmlLayoutTest by dropping " in " at the end of the string
* Further I changed PatternLayoutTest like this:
	-Assert.AreEqual("RuntimeMethodHandle._InvokeMethodFast >
PatternLayoutTest.TestStackTracePattern", stringAppender.GetString(), "stack
trace value set");
	+Assert.AreEqual("System.RuntimeMethodHandle.InvokeMethod >
log4net.Tests.Layout.PatternLayoutTest.TestStackTracePattern",
stringAppender.GetString(), "stack trace value set");
* Further I fixed the issues with leaking exception translation


Mime
View raw message