logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Tang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4NET-344) Make AdoNetAppender not to stuck application process
Date Wed, 06 Jun 2012 07:34:22 GMT

    [ https://issues.apache.org/jira/browse/LOG4NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289998#comment-13289998
] 

Tom Tang commented on LOG4NET-344:
----------------------------------

Hi, Ron:

I got your point, and thanks for that.

I have granted the ASF license on the contributed code snippet, wish to save time for merging
the feature back to official release.

Means all participants could improve it in their own opinions. 

I think team guys will improve it in the best effort if they decide to take it.

I may not walk around here and do maintenance by the way keeping submit file attachment for
minor changes.

Your advice are all wisdom. I just wouldn't do the revisions.

Cheers :)
                
> Make AdoNetAppender not to stuck application process
> ----------------------------------------------------
>
>                 Key: LOG4NET-344
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-344
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Appenders
>    Affects Versions: 1.2.10
>         Environment: Windows series
>            Reporter: Tom Tang
>              Labels: patch
>             Fix For: 3.5
>
>         Attachments: AdoNetAppender.cs, AsyncForwardingAppender.cs
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The original AdoNetAppender could stuck application during log insertion.
> Because it use the sync method call to do database insert, once the DB is unavailable
or table was locked.
> I change the implementation that has an inner queue inside to store the messages, and
the other independent thread will be going to cunsuming the queue messages and do DB insertion.
> This implementation will not have any impact on application performance and much stable.
> Trade off: Once the queue max buffer was full, the later coming log message would be
ignored and gone forever. But log4net is not designed for guarantee delivery in purpose, right?
So it's not big deal at all. :)  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message