logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LOG4NET-319) .Net 4.0 build
Date Tue, 06 Dec 2011 16:07:40 GMT

     [ https://issues.apache.org/jira/browse/LOG4NET-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Bodewig resolved LOG4NET-319.
------------------------------------

    Resolution: Invalid

The NET_2_0 define is not a subset of NET_4_0.

If you look through the code you'll find several places where NET_2_0 is meant as .NET 2.x
or better.  NET_4_0 is only there for code that requires 4.0 in addition.  With
your patch we'd actually break several things.

WRT github, with JIRA attachments you'd have a checkbox you could click in order to grant
a license to the ASF.  Without that I'd have to ask you explicitly for each patch.
                
> .Net 4.0 build
> --------------
>
>                 Key: LOG4NET-319
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-319
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Builds
>    Affects Versions: 1.2.11, 1.2.12
>         Environment: Nothing special
>            Reporter: NN
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Currently log4net.vs2010 doesn't build log4net for .Net 4.0 but for .Net 2.0
> This patch adds additional project to build only for .Net 4.0 without 2.0 dependencies.
> The change is here: https://github.com/apache/log4net/pull/2/files
> It just adds another project and puts it in solution.
> Nothing special.
> Another option is to set .Net 4.0 build for log4net.vs2010.csproj
> Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message