logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christof Nordiek (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LOG4NET-88) [PATCH] to AdoNetAppender.cs to support .NET 2.0 connectionStrings configuration section
Date Wed, 19 May 2010 09:51:54 GMT

    [ https://issues.apache.org/jira/browse/LOG4NET-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869074#action_12869074

Christof Nordiek commented on LOG4NET-88:

This hack seems only to get the connectionString attribute from the connectionString section.
It should only get the providerName from there.

> [PATCH] to AdoNetAppender.cs to support .NET 2.0 connectionStrings configuration section
> ----------------------------------------------------------------------------------------
>                 Key: LOG4NET-88
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-88
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Appenders
>    Affects Versions: 1.2.10
>         Environment: Windows XP .NET 2.0
>            Reporter: Haacked
>            Assignee: Ron Grabowski
>             Fix For: 1.2.11
>         Attachments: AdoNetAppenderConnectionStringName.patch
> This is a patch for [LOG4NET-78] https://issues.apache.org/jira/browse/LOG4NET-78.  This
adds a new "connectionStringName" attribute (and corresponding ConnectionStringName) property
to the AdoNetAppender class.  This is a reference to a connection string within the <ConnectionStrings>
section of an App.config or Web.config file.
> The choice of name "connectionStringName" is consistent with the naming that Microsoft
uses in the various Providers such as SqlMembershipProvider.
> I made sure to put this code in between #if NET_2_0 blocks. However, the patch does not
include the required change to the log4net.csproj file which needs to reference the System.Configuration.dll
(C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.configuration.dll) assembly.  
> This is a .NET 2.0 only assembly so I was unsure how to add a conditional compilation
element so that the project reference would not break log4net for .NET 1.0 and .NET 1.1. 

> If there is a better way to do so, please let me know!

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message