logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dries...@apache.org
Subject svn commit: r332751 - /logging/log4net/trunk/src/Appender/AppenderSkeleton.cs
Date Sat, 12 Nov 2005 09:34:21 GMT
Author: drieseng
Date: Sat Nov 12 01:34:19 2005
New Revision: 332751

URL: http://svn.apache.org/viewcvs?rev=332751&view=rev
Log:
Fixed warning on MS.NET 2.0 and Mono: exceptions that do no derive from
System.Exception are now wrapped in RuntimeWrappedException, so there's no
need to have a separate catch block.

Modified:
    logging/log4net/trunk/src/Appender/AppenderSkeleton.cs

Modified: logging/log4net/trunk/src/Appender/AppenderSkeleton.cs
URL: http://svn.apache.org/viewcvs/logging/log4net/trunk/src/Appender/AppenderSkeleton.cs?rev=332751&r1=332750&r2=332751&view=diff
==============================================================================
--- logging/log4net/trunk/src/Appender/AppenderSkeleton.cs (original)
+++ logging/log4net/trunk/src/Appender/AppenderSkeleton.cs Sat Nov 12 01:34:19 2005
@@ -320,11 +320,17 @@
 				{
 					ErrorHandler.Error("Failed in DoAppend", ex);
 				}
+#if !MONO && !NET_2_0
+				// on .NET 2.0 (and higher) and Mono (all profiles), 
+				// exceptions that do not derive from System.Exception will be
+				// wrapped in a RuntimeWrappedException by the runtime, and as
+				// such will be catched by the catch clause above
 				catch
 				{
 					// Catch handler for non System.Exception types
 					ErrorHandler.Error("Failed in DoAppend (unknown exception)");
 				}
+#endif
 				finally
 				{
 					m_recursiveGuard = false;
@@ -421,11 +427,17 @@
 				{
 					ErrorHandler.Error("Failed in Bulk DoAppend", ex);
 				}
+#if !MONO && !NET_2_0
+				// on .NET 2.0 (and higher) and Mono (all profiles), 
+				// exceptions that do not derive from System.Exception will be
+				// wrapped in a RuntimeWrappedException by the runtime, and as
+				// such will be catched by the catch clause above
 				catch
 				{
 					// Catch handler for non System.Exception types
 					ErrorHandler.Error("Failed in Bulk DoAppend (unknown exception)");
 				}
+#endif
 				finally
 				{
 					m_recursiveGuard = false;



Mime
View raw message