Return-Path: 
 <log4net-dev-return-606-apmail-logging-log4net-dev-archive=logging.apache.org@logging.apache.org>
Delivered-To: apmail-logging-log4net-dev-archive@www.apache.org
Received: (qmail 35487 invoked from network); 19 Dec 2004 19:25:06 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 19 Dec 2004 19:25:06 -0000
Received: (qmail 21266 invoked by uid 500); 19 Dec 2004 19:25:06 -0000
Delivered-To: apmail-logging-log4net-dev-archive@logging.apache.org
Received: (qmail 21243 invoked by uid 500); 19 Dec 2004 19:25:05 -0000
Mailing-List: contact log4net-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:log4net-dev-help@logging.apache.org>
list-unsubscribe: <mailto:log4net-dev-unsubscribe@logging.apache.org>
list-post: <mailto:log4net-dev@logging.apache.org>
Reply-To: "Log4NET Dev" <log4net-dev@logging.apache.org>
Delivered-To: mailing list log4net-dev@logging.apache.org
Received: (qmail 21229 invoked by uid 500); 19 Dec 2004 19:25:05 -0000
Delivered-To: apmail-logging-log4net-cvs@apache.org
Received: (qmail 21224 invoked by uid 99); 19 Dec 2004 19:25:05 -0000
X-ASF-Spam-Status: No, hits=-9.8 required=10.0
	tests=ALL_TRUSTED,NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from minotaur.apache.org (HELO minotaur.apache.org)
 (209.237.227.194)
  by apache.org (qpsmtpd/0.28) with SMTP; Sun, 19 Dec 2004 11:25:05 -0800
Received: (qmail 35450 invoked by uid 1808); 19 Dec 2004 19:25:04 -0000
Date: 19 Dec 2004 19:25:04 -0000
Message-ID: <20041219192504.35449.qmail@minotaur.apache.org>
From: nicko@apache.org
To: logging-log4net-cvs@apache.org
Subject: cvs commit: logging-log4net/src/Util/TypeConverters TypeConverter.cs
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

nicko       2004/12/19 11:25:04

  Modified:    src/Util/TypeConverters TypeConverter.cs
  Log:
  Updates suggested by FxCop.
  Minor naming changes to internal types.
  Perf improvements to type check + type cast code.
  
  Revision  Changes    Path
  1.2       +3 -2      logging-log4net/src/Util/TypeConverters/TypeConverter.cs
  
  Index: TypeConverter.cs
  ===================================================================
  RCS file: /home/cvs/logging-log4net/src/Util/TypeConverters/TypeConverter.cs,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TypeConverter.cs	30 Jul 2004 14:15:30 -0000	1.1
  +++ TypeConverter.cs	19 Dec 2004 19:25:04 -0000	1.2
  @@ -49,9 +49,10 @@
   		/// <returns>the Type</returns>
   		public object ConvertFrom(object source) 
   		{
  -			if (source is string) 
  +			string str = source as string;
  +			if (str != null)
   			{
  -				return SystemInfo.GetTypeFromString((string)source, true, true);
  +				return SystemInfo.GetTypeFromString(str, true, true);
   			}
   			throw ConversionNotSupportedException.Create(typeof(Type), source);
   		}