Return-Path: Delivered-To: apmail-logging-log4net-dev-archive@www.apache.org Received: (qmail 35013 invoked from network); 19 Dec 2004 19:24:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 19 Dec 2004 19:24:32 -0000 Received: (qmail 20239 invoked by uid 500); 19 Dec 2004 19:24:32 -0000 Delivered-To: apmail-logging-log4net-dev-archive@logging.apache.org Received: (qmail 20219 invoked by uid 500); 19 Dec 2004 19:24:31 -0000 Mailing-List: contact log4net-dev-help@logging.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: "Log4NET Dev" Delivered-To: mailing list log4net-dev@logging.apache.org Received: (qmail 20203 invoked by uid 500); 19 Dec 2004 19:24:31 -0000 Delivered-To: apmail-logging-log4net-cvs@apache.org Received: (qmail 20198 invoked by uid 99); 19 Dec 2004 19:24:31 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from minotaur.apache.org (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.28) with SMTP; Sun, 19 Dec 2004 11:24:31 -0800 Received: (qmail 34996 invoked by uid 1808); 19 Dec 2004 19:24:30 -0000 Date: 19 Dec 2004 19:24:30 -0000 Message-ID: <20041219192430.34995.qmail@minotaur.apache.org> From: nicko@apache.org To: logging-log4net-cvs@apache.org Subject: cvs commit: logging-log4net/src/Util/PatternStringConverters LiteralPatternConverter.cs X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N nicko 2004/12/19 11:24:30 Modified: src/Util/PatternStringConverters LiteralPatternConverter.cs Log: Updates suggested by FxCop. Minor naming changes to internal types. Perf improvements to type check + type cast code. Revision Changes Path 1.4 +3 -2 logging-log4net/src/Util/PatternStringConverters/LiteralPatternConverter.cs Index: LiteralPatternConverter.cs =================================================================== RCS file: /home/cvs/logging-log4net/src/Util/PatternStringConverters/LiteralPatternConverter.cs,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- LiteralPatternConverter.cs 23 Feb 2004 03:18:05 -0000 1.3 +++ LiteralPatternConverter.cs 19 Dec 2004 19:24:30 -0000 1.4 @@ -35,10 +35,11 @@ /// public override PatternConverter SetNext(PatternConverter pc) { - if (pc is LiteralPatternConverter) + LiteralPatternConverter literalPc = pc as LiteralPatternConverter; + if (literalPc != null) { // Combine the two adjacent literals together - Option = Option + ((LiteralPatternConverter)pc).Option; + Option = Option + literalPc.Option; // We are the next converter now return this;