logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ni...@apache.org
Subject cvs commit: logging-log4net/src/Util/TypeConverters ConverterRegistry.cs
Date Sun, 19 Dec 2004 19:24:41 GMT
nicko       2004/12/19 11:24:41

  Modified:    src/Util/TypeConverters ConverterRegistry.cs
  Log:
  Updates suggested by FxCop.
  Minor naming changes to internal types.
  Perf improvements to type check + type cast code.
  
  Revision  Changes    Path
  1.7       +4 -2      logging-log4net/src/Util/TypeConverters/ConverterRegistry.cs
  
  Index: ConverterRegistry.cs
  ===================================================================
  RCS file: /home/cvs/logging-log4net/src/Util/TypeConverters/ConverterRegistry.cs,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ConverterRegistry.cs	1 Oct 2004 21:02:16 -0000	1.6
  +++ ConverterRegistry.cs	19 Dec 2004 19:24:41 -0000	1.7
  @@ -103,8 +103,10 @@
   		public static IConvertTo GetConvertTo(Type sourceType, Type destinationType)
   		{
   			// TODO: Support inheriting type converters.
  +			// i.e. getting a type converter for a base of sourceType
  +
  +			// TODO: Is destinationType required? We don't use it for anything.
   
  -			// i.e. getting a type converter for a base of destinationType
   			// Lookup in the static registry
   			IConvertTo converter = s_registry.m_type2converter[sourceType] as IConvertTo;
   
  @@ -134,8 +136,8 @@
   		public static IConvertFrom GetConvertFrom(Type destinationType)
   		{
   			// TODO: Support inheriting type converters.
  -
   			// i.e. getting a type converter for a base of destinationType
  +
   			// Lookup in the static registry
   			IConvertFrom converter = s_registry.m_type2converter[destinationType] as IConvertFrom;
   
  
  
  

Mime
View raw message