Mailing-List: contact log4j-user-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Users List" <log4j-user@logging.apache.org>
MIME-Version: 1.0
In-Reply-To: <CACZkXPy2zJfMONbYNs2-GSt0iQVYqxqJjPmQK84Mk96LC4Mm7Q@mail.gmail.com>
References: <CACZkXPwY4YE-61sMhbQyLfYx_WQqpV0NmM-a8VOJLdfODv10Zg@mail.gmail.com>
 <CACmp6kqLFHBBP7XCQ3+C12os5K-kt+QGADwHJpR8sTkbtzGt3g@mail.gmail.com>
 <F3106601-DA14-4D42-841A-2E2F8E31D9F1@gmail.com> <CACZkXPwQ-812DXKa2wTDtTEr7VOpyacAZSKW58iZFmU7y8NZHQ@mail.gmail.com>
 <7C8777FA-A36D-4696-AB57-3E86A4B310BA@gmail.com> <CACZkXPy2zJfMONbYNs2-GSt0iQVYqxqJjPmQK84Mk96LC4Mm7Q@mail.gmail.com>
From: Matt Sicker <boards@gmail.com>
Date: Tue, 6 Sep 2016 23:07:50 -0500
Message-ID: <CACmp6kq5LDQfrnV+mmZyyX59jyaoEOMiFvZ+3smO3xT4G8NMFw@mail.gmail.com>
Subject: Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String)
 to Core?
To: Log4J Users List <log4j-user@logging.apache.org>
Content-Type: multipart/alternative; boundary=001a113dff408af79d053be30e13
archived-at: Wed, 07 Sep 2016 04:07:56 -0000

--001a113dff408af79d053be30e13
Content-Type: text/plain; charset=UTF-8

If you move it to Loader, you can just use StatusLogger. LowLevelLogUtil is
there for the classes that have to load before StatusLogger can properly
load.

On 6 September 2016 at 21:08, Gary Gregory <garydgregory@gmail.com> wrote:

> Hm, that methods depends on the package private class LowLevelLogUtil. So
> moving the method to Core would mean making LowLevelLogUtil public. I'm not
> sure that's a good tradeoff...
>
> Gary
>
> On Tue, Sep 6, 2016 at 7:44 PM, Remko Popma <remko.popma@gmail.com> wrote:
>
> > Ah! I didn't look at the code. If there's no risk of breaking user code I
> > have no objection.
> >
> > Apologies.
> >
> > Sent from my iPhone
> >
> > > On 2016/09/07, at 8:11, Gary Gregory <garydgregory@gmail.com> wrote:
> > >
> > > How could moving an API marked @since 2.7 break user code?
> > >
> > > Gary
> > >
> > >> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma <remko.popma@gmail.com>
> > wrote:
> > >>
> > >> Is there a problem that needs solving here?
> > >> I know we consider the API module's util package private, but I really
> > >> don't like making changes that could break user code for no good
> > reason...
> > >>
> > >> Sent from my iPhone
> > >>
> > >>> On 2016/09/07, at 6:36, Matt Sicker <boards@gmail.com> wrote:
> > >>>
> > >>> Might as well. If we need it in api, we can move it back later.
> > >>>
> > >>>> On 6 September 2016 at 15:54, Gary Gregory <garydgregory@gmail.com>
> > >> wrote:
> > >>>>
> > >>>> The API module method
> > >>>> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String)
> is
> > >>>> @since
> > >>>> 2.7 and is only called from the Core module. I propose we move it to
> > >> Core.
> > >>>>
> > >>>> Gary
> > >>>>
> > >>>> --
> > >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > >>>> Java Persistence with Hibernate, Second Edition
> > >>>> <http://www.manning.com/bauer3/>
> > >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > >>>> Spring Batch in Action <http://www.manning.com/templier/>
> > >>>> Blog: http://garygregory.wordpress.com
> > >>>> Home: http://garygregory.com/
> > >>>> Tweet! http://twitter.com/GaryGregory
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Matt Sicker <boards@gmail.com>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> > >> For additional commands, e-mail: log4j-user-help@logging.apache.org
> > >
> > >
> > > --
> > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> > For additional commands, e-mail: log4j-user-help@logging.apache.org
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>


-- 
Matt Sicker <boards@gmail.com>

--001a113dff408af79d053be30e13--