Mailing-List: contact log4j-user-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Users List" <log4j-user@logging.apache.org>
From: Blake Day <blake@chewy.com>
To: Log4J Users List <log4j-user@logging.apache.org>
Subject: Re: TlsSyslogFrame calculates message length incorrectly
Thread-Topic: TlsSyslogFrame calculates message length incorrectly
Thread-Index: AQHRU+bKKaAaU/R7LUa8wSC/7N07XZ8FOEWAgAAD4SGAAAPiAIAAAZgm
Date: Thu, 21 Jan 2016 02:37:47 +0000
Message-ID: <D9D90340-2C2E-447A-BAF4-D1B6BB34CD43@chewy.com>
References: <62FDFA39-3596-45C0-B1CC-D7677BCE5349@chewy.com>
	<CACZkXPxf0WkyTHfXGrOxS4htD43tj7KJ78Kr1+K5pTLDXHY=OQ@mail.gmail.com>
	<474383BE-9BC3-4D73-A259-225932A5AEB9@chewy.com>,<CACZkXPyN4zSPaJPt5LHfJKjaTi1uYXnVZffhJEb2Aa+V0nDvgw@mail.gmail.com>
In-Reply-To: 
 <CACZkXPyN4zSPaJPt5LHfJKjaTi1uYXnVZffhJEb2Aa+V0nDvgw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: chewy.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2016 02:37:47.6165
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 99879b8e-3b16-427d-902a-05eda342f629
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2120

I'm mobile so can't confirm, but utf-8 has multi-byte characters as well.

> On Jan 20, 2016, at 9:32 PM, Gary Gregory <garydgregory@gmail.com> wrote:
>=20
>> On Wed, Jan 20, 2016 at 6:18 PM, Blake Day <blake@chewy.com> wrote:
>>=20
>> I'm not sure on that, but it wouldn't fix the erroneous byte count on lo=
g
>> messages with a multi-byte unicode character.
>=20
> Please see my latest message.
>=20
> "multi-byte unicode character." Doesn't the spec call for UTF-8 as the on=
ly
> encoding?
>=20
> Gary
>=20
>=20
>>>> On Jan 20, 2016, at 9:04 PM, Gary Gregory <garydgregory@gmail.com>
>>> wrote:
>>>=20
>>> Hm, shouldn't we be using UTF-8 instead of Charset.defaultCharset() in:
>>>=20
>>>   public byte[] getBytes() {
>>>       final String frame =3D toString();
>>>       return frame.getBytes(Charset.defaultCharset());
>>>   }
>>>=20
>>> ?
>>>=20
>>> Gary
>>>=20
>>>> On Wed, Jan 20, 2016 at 4:58 PM, Blake Day <blake@chewy.com> wrote:
>>>>=20
>>>> TlsSyslogFrame appears to be miscalculating the message length.
>> According
>>>> to RFC5425, the message length must be the octet count of the
>> SYSLOG-MSG in
>>>> the frame.  Though the variable below is aptly named
>> messageLengthInBytes,
>>>> it is assigned the value from message.length() (where message is a
>> String)
>>>> rather than the bytes.
>>>>=20
>>>> See below for relevant portions of code:
>>>>=20
>>>> private String message;
>>>> private int messageLengthInBytes;
>>>>=20
>>>> private void setLengthInBytes() {
>>>>   messageLengthInBytes =3D message.length();
>>>> }
>>>>=20
>>>> @Override
>>>> public String toString() {
>>>>   final String length =3D Integer.toString(messageLengthInBytes);
>>>>   return length + Chars.SPACE + message;
>>>> }
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
>>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
>>>=20
>>>=20
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>=20
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-user-help@logging.apache.org
>=20
>=20
> --=20
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-user-help@logging.apache.org