Mailing-List: contact log4j-user-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Users List" <log4j-user@logging.apache.org>
Received-SPF: pass (athena.apache.org: domain of mariano.l.gonzalez@gmail.com
 designates 209.85.216.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAE46vqGwQFU0u2XbTwnYgesWJ+xoi2Mic6wG2_aKAUhrr=WwdA@mail.gmail.com>
References: 
 <CAE46vqEAdy212+O_qB-GBtknCw1svbunp3PXG6v2bDrPPCMBVA@mail.gmail.com>
	<7461130E-4BC7-470E-B78B-9248CA65D11E@gmail.com>
	<CAE46vqGwQFU0u2XbTwnYgesWJ+xoi2Mic6wG2_aKAUhrr=WwdA@mail.gmail.com>
Date: Fri, 19 Dec 2014 15:41:48 -0300
Message-ID: 
 <CAE46vqGZiUeqcAMMGr43QRHtjMQGOP9cSjptCZtpzYRJcT_LpA@mail.gmail.com>
Subject: Re: Race condition stopping context
From: Mariano Gonzalez <mariano.l.gonzalez@gmail.com>
To: Log4J Users List <log4j-user@logging.apache.org>
Content-Type: multipart/alternative; boundary=001a113ace06b011c3050a960f55

--001a113ace06b011c3050a960f55
Content-Type: text/plain; charset=UTF-8

Hello,

I've been taking a look at LoggerContext#stop() and for what I see there's
code to prevent disruptor to take new messages but there's nothing making
sure that the ring buffer is empty before actually closing up.

I did a simple test with an Appender wrapper like this:

final class StopConditionSafeAppenderWrapper extends BaseAppenderWrapper
{
    private final LoggerContext loggerContext;

    StopConditionSafeAppenderWrapper(Appender delegate, LoggerContext
loggerContext)
    {
        super(delegate);
        this.loggerContext = loggerContext;
    }

    @Override
    public void append(LogEvent event)
    {
        if (!loggerContext.isStarted()) {
             return;
        }

        super.append(event);
    }
}

Using this appender wrapper I still get the same error, because at the time
that append was closed the context was started but by the time disruptor
processed it it was already stopped (this I could verify with a debugger).

Should I open a bug? Any workaround you could suggest?

Thanks!

--001a113ace06b011c3050a960f55--