Mailing-List: contact log4j-user-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Users List" <log4j-user@logging.apache.org>
Received-SPF: pass (athena.apache.org: domain of ralph.goers@dslextreme.com
 designates 209.85.220.48 as permitted sender)
From: Ralph Goers <ralph.goers@dslextreme.com>
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: org.apache.loggin.log4j.core.pattern.DatePatternConverter
 blocking
In-Reply-To: 
 <CAPvyOriDX3O5UdK+uXJKG=GjFPtpTPV-YfCFDYRKjXX4Yqc6Vg@mail.gmail.com>
Date: Wed, 3 Sep 2014 21:39:39 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <BCCD58F9-20F3-4143-B3D6-9B8567A899BC@dslextreme.com>
References: 
 <CAOT3TWqQdE1C1SmP3YwtNQ+3uzHCiZtc3ca31vYKU8aCJgBU0w@mail.gmail.com>
 <E6C343A8-A3C8-4813-9F92-8C7F1E2C1893@dslextreme.com>
 <CAOT3TWpBfEqhKuRDfawA4WoY_c5mTiqk0_wHExS=yxVndC4gzw@mail.gmail.com>
 <CACmp6ko+UkGPg-PXwTVtExB7krnF_ws_aLcKP=uxQpV4BRNGfw@mail.gmail.com>
 <CAPvyOriDX3O5UdK+uXJKG=GjFPtpTPV-YfCFDYRKjXX4Yqc6Vg@mail.gmail.com>
To: Log4J Users List <log4j-user@logging.apache.org>

That seems like a good idea.

Ralph

On Sep 3, 2014, at 9:11 PM, Yogesh Rao <yogu13@gmail.com> wrote:

> How abt providing the date formatter as part of log4j itself ( on the =
lines
> of FastDateFormatter from commons-lang) ?
>=20
> Regards,
> -Yogesh
>=20
> On Thursday, September 4, 2014, Matt Sicker <boards@gmail.com> wrote:
>=20
>> Is it not possible to just use ThreadLocal? Is that not safe enough =
or does
>> it waste too many resources?
>>=20
>>=20
>> On 3 September 2014 18:39, Mohit Anchlia <mohitanchlia@gmail.com
>> <javascript:;>> wrote:
>>=20
>>> Issue created
>>>=20
>>> https://issues.apache.org/jira/browse/LOG4J2-812
>>>=20
>>>=20
>>> On Wed, Sep 3, 2014 at 4:28 PM, Ralph Goers =
<ralph.goers@dslextreme.com
>> <javascript:;>>
>>> wrote:
>>>=20
>>>> The converter uses a SimpleDateFormat which is not thread safe and =
so
>> is
>>>> synchronized. I am sure there might be minor optimizations that =
could
>> be
>>>> done to this
>>>>=20
>>>> What I would do is modify DatePatternConverter to
>>>> a) use Java 8=92s java.time.format.DateTimeFormatter if running on =
Java 8
>>>> b) use Joda Time=92s DateTimeFormat if it is present.
>>>> c) create a pool of SimpleDateFormat objects and use those.
>>>>=20
>>>> Please create a Jira issue for this.
>>>>=20
>>>> Ralph
>>>>=20
>>>> On Sep 3, 2014, at 3:00 PM, Mohit Anchlia <mohitanchlia@gmail.com
>> <javascript:;>>
>>> wrote:
>>>>=20
>>>>> I am using log4j2 and I am seeing almost all the threads
>>>>> momentarily getting blocked on
>>>>> org.apache.loggin.log4j.core.pattern.DatePatternConverter class. =
Is
>>> this
>>>>> expected?
>>>>=20
>>>>=20
>>>> =
---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
>> <javascript:;>
>>>> For additional commands, e-mail: log4j-user-help@logging.apache.org
>> <javascript:;>
>>>>=20
>>>>=20
>>>=20
>>=20
>>=20
>>=20
>> --
>> Matt Sicker <boards@gmail.com <javascript:;>>
>>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-user-help@logging.apache.org