logging-log4j-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "DeSantis, MJ Mark @ IS (7179)" <Mark.J.DeSan...@L-3com.com>
Subject JmsAppender bug?
Date Thu, 02 Feb 2006 18:33:08 GMT
I'm lost,
 
has anyone succesfully used the JmsAppender from the alpha-7 build?
 
perhaps I'm missing something but in the code for the activateOptions()
method of JmsAppender i see this 
 
 
if (this.topicConnection != null && this.topicSession != null &&
this.topicPublisher == null) {
    inOrder = true;
} else {
    inOrder = false;
}
 
the field inOrder only gets set true if topicConnection is not null, and if
topicSession is not null, and if topicPublisher IS null! the inOrder field
is used in the append method as follows:
 
public void append(LoggingEvent event) {
    if (!inOrder) {
        return;
    }
 
    //.....send message
}
 
So if the topicPublisher field was not null then the inOrder field gets set
to false and the append method would do nothing as it returns immediately.
 
I think activateOptions() if statement needs to read:
 
if (this.topicConnection != null && this.topicSession != null &&
this.topicPublisher != null) {
 
 
 
Perhaps I'm missing something.
 
Could someone look into this if possible, or let me know that my logic is
wrong, or something.
 
 
Mark
 

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message