Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Date: Mon, 10 Apr 2017 15:39:41 +0000 (UTC)
From: "Gary Gregory (JIRA)" <jira@apache.org>
To: log4j-dev@logging.apache.org
Message-ID: <JIRA.13062789.1491804484000.248630.1491838781761@Atlassian.JIRA>
In-Reply-To: <JIRA.13062789.1491804484000@Atlassian.JIRA>
References: <JIRA.13062789.1491804484000@Atlassian.JIRA> <JIRA.13062789.1491804484968@jira-lw-us.apache.org>
Subject: [jira] [Commented] (LOG4J2-1873) Implement UTF-8 encoding that
 doesn't use CharsetEncoder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Apr 2017 15:39:45 -0000


    [ https://issues.apache.org/jira/browse/LOG4J2-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963050#comment-15963050 ] 

Gary Gregory commented on LOG4J2-1873:
--------------------------------------

ICU4J might have something we can optionally depend on or copy.

> Implement UTF-8 encoding that doesn't use CharsetEncoder
> --------------------------------------------------------
>
>                 Key: LOG4J2-1873
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1873
>             Project: Log4j 2
>          Issue Type: Improvement
>            Reporter: Roman Leventov
>
> CharsetEncoder accepts only CharBuffers, and for the sake of being entirely garbage-free we don't want to use CharBuffer.wrap(stringBuilder), when encoding an event.
> That forces us to make additional data copy from StringBuilder to a thread-local CharBuffer.
> This could be avoided by implementing UTF-8 encoding logic in log4j-core itself, and not using CharsetEncoder.
> This issue is specifically about UTF-8 because it is used predominantly and it's relatively easy to implement. There are also likely some open-source Apache 2-compatible implementations in Java out there already that we could just copy and adapt.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org