Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Date: Mon, 27 Mar 2017 10:33:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: log4j-dev@logging.apache.org
Message-ID: <JIRA.13057626.1490034697000.129969.1490610822152@Atlassian.JIRA>
In-Reply-To: <JIRA.13057626.1490034697000@Atlassian.JIRA>
References: <JIRA.13057626.1490034697000@Atlassian.JIRA> <JIRA.13057626.1490034697386@jira-lw-us.apache.org>
Subject: [jira] [Commented] (LOG4J2-1854) Gelf TCP endpoint
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 27 Mar 2017 10:33:50 -0000


    [ https://issues.apache.org/jira/browse/LOG4J2-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943022#comment-15943022 ] 

ASF GitHub Bot commented on LOG4J2-1854:
----------------------------------------

Github user mikaelstaldal commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/67#discussion_r108137284
  
    --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java ---
    @@ -237,11 +241,11 @@ public B setAdditionalFields(KeyValuePair[] additionalFields) {
         @Deprecated
         public GelfLayout(final String host, final KeyValuePair[] additionalFields, final CompressionType compressionType,
                           final int compressionThreshold, final boolean includeStacktrace) {
    -        this(null, host, additionalFields, compressionType, compressionThreshold, includeStacktrace, true);
    +        this(null, host, additionalFields, compressionType, compressionThreshold, includeStacktrace, true, false);
    --- End diff --
    
    Please do not change this method since that will break binary compatibility. Users will have to use builder to use the new feature.


> Gelf TCP endpoint 
> ------------------
>
>                 Key: LOG4J2-1854
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1854
>             Project: Log4j 2
>          Issue Type: Bug
>            Reporter: Xavier Jodoin
>            Priority: Minor
>
> Gelf TCP endpoint need a NULL-byte between each messages and it doesn't support compression


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org