Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D814D200C39 for ; Thu, 16 Mar 2017 15:56:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D6BD3160B7A; Thu, 16 Mar 2017 14:56:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6D0A160B78 for ; Thu, 16 Mar 2017 15:56:04 +0100 (CET) Received: (qmail 76685 invoked by uid 500); 16 Mar 2017 14:56:03 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 76675 invoked by uid 99); 16 Mar 2017 14:56:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 14:56:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7BA9A18F15A for ; Thu, 16 Mar 2017 14:56:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.879 X-Spam-Level: * X-Spam-Status: No, score=1.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YWqbtOqHO10d for ; Thu, 16 Mar 2017 14:56:01 +0000 (UTC) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 800985FC7B for ; Thu, 16 Mar 2017 14:56:00 +0000 (UTC) Received: by mail-lf0-f52.google.com with SMTP id a6so21451696lfa.0 for ; Thu, 16 Mar 2017 07:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=u0HwPmIL6dmQCWPnO75RAC6gmHyCbLiOZVuINNthCv4=; b=uolWBCtIXsWvDvsICSW/RSZpXj3dwfY3AgL9U/90kpXpdY6udaNXWvm/dsuX0X0e8u POKVHLF++hGaZ39CwORKDrMMsaGOK6lLdWZZF+ELRwnGcEbIDc9aWbOfBPHG46aiFNGd Dqq2xfdtKByhCv5pQ0COTqnXDev1eudntnxWTaSWhaZmVFBlePLJf0qRTVTO1SLOk5Yz GSBWq5YHiP2csU9B8Quk4OXM8VD3e/uyCk9OI2M6EoSCXCYoBY9RnlBUTtwDQckCFNUn NfB4GHcDsmRHUgkh5VvrWEuBupoS6ABznzfepPzzASN3hUuZ6R3a0OiZhqWlwZgurzAU PUmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=u0HwPmIL6dmQCWPnO75RAC6gmHyCbLiOZVuINNthCv4=; b=ikVtDDNwx08yZheDH8Vezf26c5T5LDqc7JiAtoF8M1t3Wkl8oxsUz9157anBUZdBos PvRXIeXR0kocSe1YS9CUJRi8UmNdmz5XWfEZoBDjXAiinWDzbN/KSNVEJpTi25A6MaIX B96sc9kU0aHx2gkBn5HjyFPxLXHdONtesTiFrL94vACkVOYJvlROeWUFnSfR1q3VbGtK yvtF77DNPYsAfcUhBCydREjciuxIuBZP08t9Yr8Fko3RueqOwu1AQR9eVBVw7pUQuQKW UsfnBIvdGQDezCKg4pj3GmE5SY/ckKIDrjFkoKQwk6x966dZVVJBAnpA10giDVsUWrja mfZw== X-Gm-Message-State: AFeK/H0Jrs8HhmXqSAkKx2cwjX2DsJne45xw+n3abTkChpFppUxQM4dvJB2RP1iRUACIxpaF0VUAz38D5im3mQ== X-Received: by 10.46.33.209 with SMTP id h78mr3261724lji.53.1489676153675; Thu, 16 Mar 2017 07:55:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.227.77 with HTTP; Thu, 16 Mar 2017 07:55:52 -0700 (PDT) In-Reply-To: <01EF2A48-C2C8-42B0-85AD-12C346160896@dslextreme.com> References: <70618055-7A4F-4C93-AD2B-59A2E0A62F03@dslextreme.com> <01EF2A48-C2C8-42B0-85AD-12C346160896@dslextreme.com> From: Matt Sicker Date: Thu, 16 Mar 2017 09:55:52 -0500 Message-ID: Subject: Re: Java 9 support To: Log4J Developers List Content-Type: multipart/alternative; boundary=001a1142c810f86845054ada41c0 archived-at: Thu, 16 Mar 2017 14:56:06 -0000 --001a1142c810f86845054ada41c0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable OSGi and Jigsaw have considerable overlap in concepts, so I'm assuming there will be integration efforts eventually. However, a friend went to JavaOne a year or two ago, and the Jigsaw folk were very dismissive of OSGi in general despite one of the leading OSGi spec leads being on the Jigsaw project. On 16 March 2017 at 08:37, Ralph Goers wrote: > Nevermind. I moved the dependency plugin after the bundle plugin so that > the classes are copied after the bundle plugin runs and all is well. I ha= ve > no idea how that will impact the OSGi bundle though. Then again, I have n= o > idea if OSGi will support multi-release jars. > > Ralph > > On Mar 15, 2017, at 11:36 PM, Ralph Goers > wrote: > > I have built the Java 9 code. Now I am copying the classes into the > log4j-api jar. They have to be placed at META-INF/versions/9. However, wh= en > I do this I am getting an error from the Maven bundle plugin. > > [INFO] --- maven-bundle-plugin:3.2.0:manifest (default) @ log4j-api --- > [ERROR] Manifest org.apache.logging.log4j:log4j-api:jar:2.8.2-SNAPSHOT : > Classes found in the wrong directory: {META-INF/versions/9/org/ > apache/logging/log4j/util/ReflectionUtil.class=3Dorg. > apache.logging.log4j.util.ReflectionUtil, META-INF/versions/9/org/ > apache/logging/log4j/util/ClassPredicate.class=3Dorg. > apache.logging.log4j.util.ClassPredicate, META-INF/versions/9/org/ > apache/logging/log4j/util/ClassNamePredicate.class=3Dorg. > apache.logging.log4j.util.ClassNamePredicate} > [ERROR] Error(s) found in manifest configuration > > Any idea on how to get around this? > > Ralph > > > > > > On Mar 15, 2017, at 9:14 AM, Ralph Goers > wrote: > > I don=E2=80=99t see a problem with it. What is released will still run fi= ne on > Java 7. It will just have some Java 9 components in the jar. The release > is scheduled for late July. I haven=E2=80=99t seen any indication that it= will be > pushed again. I would rather be ready to take advantage of Java 9 on the > day it is released then be playing catch-up. > > Ralph > > On Mar 15, 2017, at 8:38 AM, Mikael St=C3=A5ldal > wrote: > > It would be bad to require Java 9 to build the main project as long as > Java 9 is not released. > > On Wed, Mar 15, 2017 at 4:27 PM, Ralph Goers > wrote: > >> I can=E2=80=99t change the JDK from JDK 1.7. The rest of the build must = be >> compiled at Java 7 since that is what we support. I only want to compile >> the new classes with Java 9. >> >> Using a profile is a very good solution. We would have to run the build >> twice but that would be OK. I will give that a try. >> >> Ralph >> >> On Mar 15, 2017, at 8:13 AM, Matt Sicker wrote: >> >> You can change the JDK from "JDK 1.7 (latest)" to one of the JDK 9 >> versions. Since there's no official release of 9 yet, they don't seem to >> have a "JDK 9 (latest)" profile set up on Jenkins yet. >> >> As for building this, the best solution I've seen so far basically >> involves a bit of manual configuration using some inline ant tasks or >> similar overly complicated nonsense which doesn't work well in any IDE t= o >> date. It may be worth investigating the existing maven plugin ecosystem = and >> seeing if we need a custom plugin developed for this. Could be a useful >> feature addition to maven-compiler-plugin, though I haven't tried >> contributing to Maven yet. >> >> Using Maven profiles would help with this so that we can still build mos= t >> of the project locally with JDK 1.7 or 1.8 as I doubt everyone wants to >> install JDK 9 on all their development machines while it's still in beta= . >> >> On 15 March 2017 at 10:07, Ralph Goers >> wrote: >> >>> I know how to implement the StackWalker code but I don=E2=80=99t quite = know how >>> to get it into the build. The main build needs to keep using Java 7 but= of >>> course the StackWalker stuff needs to be compiled with Java 9. Technica= lly, >>> I know how I could do that except I have no idea how it would work in >>> Jenkins. It would also mean that everyone would be required to have Jav= a 9 >>> installed in order to do the build. >>> >>> An alternate approach would be to have the Java 9 specific classes in a >>> separate repo with its own build. It would have to be =E2=80=9Creleased= =E2=80=9D but we >>> really wouldn=E2=80=99t need or want to release those jars to Maven Cen= tral as they >>> would only be needed in the Log4j build - the classes would be copied i= nto >>> the Log4j jar. >>> >>> If any of you know we can set a Jenkins variable to point to the latest >>> Java 9 version that could solve the problem. >>> >>> Ralph >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org >>> For additional commands, e-mail: log4j-dev-help@logging.apache.org >>> >>> >> >> >> -- >> Matt Sicker >> >> >> > > > -- > [image: MagineTV] > > *Mikael St=C3=A5ldal* > Senior software developer > > *Magine TV* > mikael.staldal@magine.com > Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com > > Privileged and/or Confidential Information may be contained in this > message. If you are not the addressee indicated in this message > (or responsible for delivery of the message to such a person), you may no= t > copy or deliver this message to anyone. In such case, > you should destroy this message and kindly notify the sender by reply > email. > > > > > --=20 Matt Sicker --001a1142c810f86845054ada41c0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
OSGi and Jigsaw have considerable overlap in concepts, so = I'm assuming there will be integration efforts eventually. However, a f= riend went to JavaOne a year or two ago, and the Jigsaw folk were very dism= issive of OSGi in general despite one of the leading OSGi spec leads being = on the Jigsaw project.

On 16 March 2017 at 08:37, Ralph Goers <ralph.goers@ds= lextreme.com> wrote:
Nevermind. I moved the dependency plugin= after the bundle plugin so that the classes are copied after the bundle pl= ugin runs and all is well. I have no idea how that will impact the OSGi bun= dle though. Then again, I have no idea if OSGi will support multi-release j= ars.

Ralph

On Mar 15, 2017, at 11:36 PM, Ralph Goers <ralph.goers@dslextreme.co= m> wrote:

I have built the Java = 9 code. Now I am copying the classes into the log4j-api jar. They have to b= e placed at META-INF/versions/9. However, when I do this I am getting an er= ror from the Maven bundle plugin.

[INFO] --- maven-bundle-plugin:3.2.0:manifest (default) @ log4j-a= pi ---
[ERROR] Manifest org.apache.logging= .log4j:log4j-api:jar:2.8.2-SNAPSHOT : Classes found in the wrong direc= tory: {META-INF/versions/9/org/apache/logging/log4j/util/Reflecti= onUtil.class=3Dorg.apache.logging.log4j.util.ReflectionUtil, META= -INF/versions/9/org/apache/logging/log4j/util/ClassPredicate.clas= s=3Dorg.apache.logging.log4j.util.ClassPredicate, META-INF/versio= ns/9/org/apache/logging/log4j/util/ClassNamePredicate.class=3Dorg= .apache.logging.log4j.util.ClassNamePredicate}
[ERROR] Error(s) found in manifest configuration

Any idea = on how to get around this?

Ralph





On Mar 15= , 2017, at 9:14 AM, Ralph Goers <ralph.goers@dslextreme.com> wrote:
I don=E2=80=99t see a problem with it. What is = released will still run fine on Java 7. It will just have some Java 9 compo= nents in the jar.=C2=A0 The release is scheduled for late July. I haven=E2= =80=99t seen any indication that it will be pushed again. I would rather be= ready to take advantage of Java 9 on the day it is released then be playin= g catch-up.

Ralph

On Mar 15, 2017, at 8:38 AM, Mikael St=C3=A5ldal <mikael.staldal@magi= ne.com> wrote:

It would be bad to require Java 9 to buil= d the main project as long as Java 9 is not released.

On Wed, Mar 15, 2017 at 4:27 PM, = Ralph Goers <ralph.goers@dslextreme.com> wrote:
=
I c= an=E2=80=99t change the JDK from JDK 1.7. The rest of the build must be com= piled at Java 7 since that is what we support. I only want to compile the n= ew classes with Java 9.

Using a profile is a very = good solution. We would have to run the build twice but that would be OK.= =C2=A0 I will give that a try.

Ralph

On Mar 15, 2017, at 8:13 AM, Matt Sicker <boards@gmail.com> wrote:

<= div>
You can change the JDK from "JDK 1.7 (latest)&quo= t; to one of the JDK 9 versions. Since there's no official release of 9= yet, they don't seem to have a "JDK 9 (latest)" profile set = up on Jenkins yet.

As for building this, the best soluti= on I've seen so far basically involves a bit of manual configuration us= ing some inline ant tasks or similar overly complicated nonsense which does= n't work well in any IDE to date. It may be worth investigating the exi= sting maven plugin ecosystem and seeing if we need a custom plugin develope= d for this. Could be a useful feature addition to maven-compiler-plugin, th= ough I haven't tried contributing to Maven yet.

Using Maven profiles would help with this so that we can still build most= of the project locally with JDK 1.7 or 1.8 as I doubt everyone wants to in= stall JDK 9 on all their development machines while it's still in beta.=

On 15= March 2017 at 10:07, Ralph Goers <ralph.goers@dslextreme.com= > wrote:
I know how to implemen= t the StackWalker code but I don=E2=80=99t quite know how to get it into th= e build. The main build needs to keep using Java 7 but of course the StackW= alker stuff needs to be compiled with Java 9. Technically, I know how I cou= ld do that except I have no idea how it would work in Jenkins. It would als= o mean that everyone would be required to have Java 9 installed in order to= do the build.

An alternate approach would be to have the Java 9 specific classes in a sep= arate repo with its own build. It would have to be =E2=80=9Creleased=E2=80= =9D but we really wouldn=E2=80=99t need or want to release those jars to Ma= ven Central as they would only be needed in the Log4j build - the classes w= ould be copied into the Log4j jar.

If any of you know we can set a Jenkins variable to point to the latest Jav= a 9 version that could solve the problem.

Ralph

-----------------------------------------------------------------= ----
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org




--
Matt Sicker <boards@gmail.com>




--
3D"MagineTV"

Mikael St=C3=A5ldal
Senior software developer

Magine TV
mikael.s= taldal@magine.com=C2=A0 =C2=A0=C2=A0
Grev Turegatan 3 =C2=A0|=C2=A0114 46 St= ockholm, Sweden=C2=A0 | =C2=A0 www.magine.com

Privilege= d and/or Confidential Information may be contained in this message. If=20 you are not the addressee indicated in this message
(or responsible for delivery of the message to such a person), you may not copy or deliver this message to anyone. In such case,=C2=A0
you should destroy this message and kindly notify the sender by reply ema= il. =C2=A0=C2=A0






--
Matt Sicker <boards@gmail.com>
--001a1142c810f86845054ada41c0--