logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1854) Gelf TCP endpoint
Date Mon, 27 Mar 2017 10:33:42 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943022#comment-15943022
] 

ASF GitHub Bot commented on LOG4J2-1854:
----------------------------------------

Github user mikaelstaldal commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/67#discussion_r108137284
  
    --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java
---
    @@ -237,11 +241,11 @@ public B setAdditionalFields(KeyValuePair[] additionalFields) {
         @Deprecated
         public GelfLayout(final String host, final KeyValuePair[] additionalFields, final
CompressionType compressionType,
                           final int compressionThreshold, final boolean includeStacktrace)
{
    -        this(null, host, additionalFields, compressionType, compressionThreshold, includeStacktrace,
true);
    +        this(null, host, additionalFields, compressionType, compressionThreshold, includeStacktrace,
true, false);
    --- End diff --
    
    Please do not change this method since that will break binary compatibility. Users will
have to use builder to use the new feature.


> Gelf TCP endpoint 
> ------------------
>
>                 Key: LOG4J2-1854
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1854
>             Project: Log4j 2
>          Issue Type: Bug
>            Reporter: Xavier Jodoin
>            Priority: Minor
>
> Gelf TCP endpoint need a NULL-byte between each messages and it doesn't support compression



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message