logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace
Date Tue, 07 Mar 2017 16:27:38 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899700#comment-15899700
] 

ASF GitHub Bot commented on LOG4J2-1838:
----------------------------------------

Github user xnslong commented on the issue:

    https://github.com/apache/logging-log4j2/pull/61
  
    I agree with you on the way how the options should stay. Maybe we can do it later for
an improvement. 
    
    And about the next issue, the pattern you provide here slightly looks like the `replace`
pattern `%replace{%xEx}{%n}{replacement}`. But this design may have to render out the `%xEx`
stack trace and the suffix first, and process with them by replacing `<LF>` characters
with the `suffix + <LF>`. This will be a little costly, I think. Because, we have to
build a big string (the stack trace) first, and do some matching operations and generate another
big string. With the option style, we can build the finally stack trace directly, without
having to process a second time. 


> Add support for appending common suffix to each line of throwable stack trace
> -----------------------------------------------------------------------------
>
>                 Key: LOG4J2-1838
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1838
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Pattern Converters
>    Affects Versions: 2.8.1
>            Reporter: Zilong Song
>              Labels: features
>             Fix For: 2.8.2
>
>
> Add support for appending common suffix to each line of throwable stack trace. The suffix
can be configured by patterns just like patterns used elsewhere. 
> For example, pattern {{%xEx&#123;suffix(- %mdc&#123;key&#125;)&#125;}}
will append a string generated by pattern {{-&#32;}}  and {{%mdc&#123;key&#125;}}.
> But patterns that handles throwable will be automatically ignored, because they will
make the rendered result confusing. So pattern {{%xEx&#123;suffix(- %rEx%mdc&#123;key&#125;)&#125;}}
has the same effect with {{%xEx&#123;suffix(- %mdc&#123;key&#125;)&#125;}},
as if the nested {{%rEx}} pattern has never appeared.
> Following is an example of the with such suffix: 
> {code:title=stack trace, with pattern "%xEx&#123;suffix(- %mdc&#123;key&#125;)&#125;"
and MDC(key)="test mdc suffix"|borderStyle=solid}
> java.lang.IllegalArgumentException: IllegalArgument - test mdc suffix
> 	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:48)
[test-classes/:?] - test mdc suffix
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91] - test
mdc suffix
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_91] - test mdc suffix
> 	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91] - test mdc suffix
> 	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147) [idea_rt.jar:?]
- test mdc suffix
> Caused by: java.lang.NullPointerException: null pointer - test mdc suffix
> 	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:47)
~[test-classes/:?] - test mdc suffix
> 	... 27 more - test mdc suffix
> }}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message