logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-969) Refactor SyslogAppender so that Layout is a Plugin element
Date Fri, 03 Mar 2017 19:27:45 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894898#comment-15894898
] 

ASF GitHub Bot commented on LOG4J2-969:
---------------------------------------

Github user rgoers commented on the issue:

    https://github.com/apache/logging-log4j2/pull/46
  
    LOG4J2-969 was closed. Is this patch still necessary?


> Refactor SyslogAppender so that Layout is a Plugin element 
> -----------------------------------------------------------
>
>                 Key: LOG4J2-969
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-969
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Appenders, Layouts
>    Affects Versions: 2.2
>            Reporter: Paul D Johe
>            Assignee: Gary Gregory
>              Labels: syslog, syslogappender
>             Fix For: 2.8
>
>
> There are quite a lot of attributes to the syslogappender that could have been simply
included as:
> {code}
> @PluginElement("layout") Layout<? extends Serializable> layout,
> {code}
> This is much more flexible (for example, extension of existing syslog layouts) and the
field 'format' becomes superfluous, as it is implied by the layout chosen (normally SyslogLayout
or Rfc5424Layout will be chosen).
> Furthermore, it becomes much clearer which attributes are for the RFC5424 format and
which are for the BSD format.
> Or at least add the possibility for a Layout element, which if does not exist will use
the existing code. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message