From log4j-dev-return-49926-apmail-logging-log4j-dev-archive=logging.apache.org@logging.apache.org Mon Feb 20 09:41:46 2017 Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B9BD19792 for ; Mon, 20 Feb 2017 09:41:46 +0000 (UTC) Received: (qmail 38011 invoked by uid 500); 20 Feb 2017 09:41:46 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 37910 invoked by uid 500); 20 Feb 2017 09:41:46 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 37900 invoked by uid 99); 20 Feb 2017 09:41:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Feb 2017 09:41:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C1BA3C6AC3 for ; Mon, 20 Feb 2017 09:41:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.799 X-Spam-Level: * X-Spam-Status: No, score=1.799 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cDZD6NeZZLIO for ; Mon, 20 Feb 2017 09:41:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 016615FC41 for ; Mon, 20 Feb 2017 09:41:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6BE3AE053A for ; Mon, 20 Feb 2017 09:41:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 27BBD2411F for ; Mon, 20 Feb 2017 09:41:44 +0000 (UTC) Date: Mon, 20 Feb 2017 09:41:44 +0000 (UTC) From: =?utf-8?Q?Mikael_St=C3=A5ldal_=28JIRA=29?= To: log4j-dev@logging.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LOG4J2-1807) [core] Add and implement LogEvent.toImmutable() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LOG4J2-1807?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D158= 74266#comment-15874266 ]=20 Mikael St=C3=A5ldal commented on LOG4J2-1807: ---------------------------------------- Given that we are not very happy with this, I think we should avoid exposin= g new public methods, so that we don't tie us further into a suboptimal des= ign. The first one (one-arg) is new and not released yet, so we can change it if= we want to. First, the new non-static {{Log4jLogEvent.createMemento}} can be removed si= nce it is not used anywhere. Then, the new static one-arg {{Log4jLogEvent.c= reateMemento}} can be renamed to something else. What do we need to maintain binary compatibility in the {{org.apache.loggin= g.log4j.core.impl}} package? > [core] Add and implement LogEvent.toImmutable() > ----------------------------------------------- > > Key: LOG4J2-1807 > URL: https://issues.apache.org/jira/browse/LOG4J2-1807 > Project: Log4j 2 > Issue Type: New Feature > Affects Versions: 2.8.1 > Reporter: Gary Gregory > Assignee: Gary Gregory > Attachments: logging-log4j2.patch > > > [core] Add and implement LogEvent.asImmutable() > {code:java} > /** > * Returns an immutable version of this log event, which MAY BE a cop= y of this event. > * =20 > * @return an immutable version of this log event > */ > LogEvent asImmutable(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org For additional commands, e-mail: log4j-dev-help@logging.apache.org