From log4j-dev-return-49742-apmail-logging-log4j-dev-archive=logging.apache.org@logging.apache.org Fri Feb 10 12:53:46 2017 Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 88B2D19241 for ; Fri, 10 Feb 2017 12:53:46 +0000 (UTC) Received: (qmail 87575 invoked by uid 500); 10 Feb 2017 12:53:46 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 87527 invoked by uid 500); 10 Feb 2017 12:53:45 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 87515 invoked by uid 99); 10 Feb 2017 12:53:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Feb 2017 12:53:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 143FAC05D7 for ; Fri, 10 Feb 2017 12:53:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jaGlAjGsvF5G for ; Fri, 10 Feb 2017 12:53:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 30D605FE07 for ; Fri, 10 Feb 2017 12:53:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 287EEE031F for ; Fri, 10 Feb 2017 12:53:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A4ED521D66 for ; Fri, 10 Feb 2017 12:53:41 +0000 (UTC) Date: Fri, 10 Feb 2017 12:53:41 +0000 (UTC) From: "Philipp Knobel (JIRA)" To: log4j-dev@logging.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LOG4J2-1678) (GC) Avoid allocating temporary objects in ThreadContextMapFilter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LOG4J2-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861217#comment-15861217 ] Philipp Knobel commented on LOG4J2-1678: ---------------------------------------- If I'm not mistaken, this filter was effectively broken after the additional filter methods where introduced until 2.8. As the fallback in AbstractFilter would kick in, which simply did a return Result.NEUTRAL. > (GC) Avoid allocating temporary objects in ThreadContextMapFilter > ----------------------------------------------------------------- > > Key: LOG4J2-1678 > URL: https://issues.apache.org/jira/browse/LOG4J2-1678 > Project: Log4j 2 > Issue Type: Improvement > Components: Filters > Affects Versions: 2.7 > Reporter: Remko Popma > Assignee: Remko Popma > Fix For: 2.8 > > > Make ThreadContextMapFilter garbage-free. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org For additional commands, e-mail: log4j-dev-help@logging.apache.org