logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remko Popma (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LOG4J2-1595) (GC) Avoid allocating temporary objects in Filter implementations
Date Tue, 08 Nov 2016 16:31:58 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Remko Popma updated LOG4J2-1595:
--------------------------------
    Description: 
Review current Filter implementation classes and change them to be garbage-free where feasible.
Document on the web site which filters are garbage free and which are not.

h4. Current status

* (-) BurstFilter (allocates, non-trivial to change)
* (/) CompositeFilter (adding & removing elements produces garbage for thread safety,
no allocation in steady state) - since 2.6
* (/) DynamicThresholdFilter (garbage free since 2.6)
* (/) LevelRangeFilter (garbage free since 2.8)
* (/) MapFilter (garbage free since 2.8, but logging a MapMessage still allocates)
* (/) MarkerFilter  (garbage free since 2.8)
* (-) RegexFilter (not garbagefree due to JDK regex library)
* (-) ScriptFilter (not garbagefree: creates new Binding object for each event)
* StructuredDataFilter (TBD)
* (/) ThreadContextMapFilter  (garbage free since 2.8)
* (/) ThresholdFilter (garbage free since 2.8)
* TimeFilter (uses Calendar to calculate millisSinceMidnight for each event. Can refactor
by reusing some of the FixedDateFormat logic.)

  was:
Review current Filter implementation classes and change them to be garbage-free where feasible.
Document on the web site which filters are garbage free and which are not.

h4. Current status

* (-) BurstFilter (allocates, non-trivial to change)
* (/) CompositeFilter (adding & removing elements produces garbage for thread safety,
no allocation in steady state) - since 2.6
* (/) DynamicThresholdFilter (garbage free since 2.6)
* (/) LevelRangeFilter (garbage free since 2.8)
* (/) MapFilter (garbage free since 2.8, but needs LOG4J2-1683 since MapMessage allocates
during filtering and logging)
* (/) MarkerFilter  (garbage free since 2.8)
* (-) RegexFilter (not garbagefree due to JDK regex library)
* (-) ScriptFilter (not garbagefree: creates new Binding object for each event)
* StructuredDataFilter (TBD)
* (/) ThreadContextMapFilter  (garbage free since 2.8)
* (/) ThresholdFilter (garbage free since 2.8)
* TimeFilter (uses Calendar to calculate millisSinceMidnight for each event. Can refactor
by reusing some of the FixedDateFormat logic.)


> (GC) Avoid allocating temporary objects in Filter implementations
> -----------------------------------------------------------------
>
>                 Key: LOG4J2-1595
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1595
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Filters
>    Affects Versions: 2.6.2
>            Reporter: Remko Popma
>            Assignee: Remko Popma
>             Fix For: 2.8
>
>
> Review current Filter implementation classes and change them to be garbage-free where
feasible. Document on the web site which filters are garbage free and which are not.
> h4. Current status
> * (-) BurstFilter (allocates, non-trivial to change)
> * (/) CompositeFilter (adding & removing elements produces garbage for thread safety,
no allocation in steady state) - since 2.6
> * (/) DynamicThresholdFilter (garbage free since 2.6)
> * (/) LevelRangeFilter (garbage free since 2.8)
> * (/) MapFilter (garbage free since 2.8, but logging a MapMessage still allocates)
> * (/) MarkerFilter  (garbage free since 2.8)
> * (-) RegexFilter (not garbagefree due to JDK regex library)
> * (-) ScriptFilter (not garbagefree: creates new Binding object for each event)
> * StructuredDataFilter (TBD)
> * (/) ThreadContextMapFilter  (garbage free since 2.8)
> * (/) ThresholdFilter (garbage free since 2.8)
> * TimeFilter (uses Calendar to calculate millisSinceMidnight for each event. Can refactor
by reusing some of the FixedDateFormat logic.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message