logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-969) Refactor SyslogAppender so that Layout is a Plugin element
Date Wed, 05 Oct 2016 13:34:21 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548717#comment-15548717
] 

ASF GitHub Bot commented on LOG4J2-969:
---------------------------------------

GitHub user doumdoum opened a pull request:

    https://github.com/apache/logging-log4j2/pull/46

    add configurable syslog layout

    Implements configurable syslog message as sketched in:
    https://issues.apache.org/jira/browse/LOG4J2-969.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/doumdoum/logging-log4j2 LOG4J2-969

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit d0882fab96f9fcaa2764a3c6d5348b2fe7005f8e
Author: Dominique Villard <dominique.villard@orange.com>
Date:   2016-10-05T13:25:00Z

    add configurable syslog layout

----


> Refactor SyslogAppender so that Layout is a Plugin element 
> -----------------------------------------------------------
>
>                 Key: LOG4J2-969
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-969
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Appenders, Layouts
>    Affects Versions: 2.2
>            Reporter: Paul D Johe
>              Labels: syslog, syslogappender
>
> There are quite a lot of attributes to the syslogappender that could have been simply
included as:
> {code}
> @PluginElement("layout") Layout<? extends Serializable> layout,
> {code}
> This is much more flexible (for example, extension of existing syslog layouts) and the
field 'format' becomes superfluous, as it is implied by the layout chosen (normally SyslogLayout
or Rfc5424Layout will be chosen).
> Furthermore, it becomes much clearer which attributes are for the RFC5424 format and
which are for the BSD format.
> Or at least add the possibility for a Layout element, which if does not exist will use
the existing code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message