Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Date: Mon, 19 Sep 2016 08:44:20 +0000 (UTC)
From: =?utf-8?Q?Mikael_St=C3=A5ldal_=28JIRA=29?= <jira@apache.org>
To: log4j-dev@logging.apache.org
Message-ID: <JIRA.13005740.1474188758000.603121.1474274660511@Atlassian.JIRA>
In-Reply-To: <JIRA.13005740.1474188758000@Atlassian.JIRA>
References: <JIRA.13005740.1474188758000@Atlassian.JIRA> <JIRA.13005740.1474188758132@arcas>
Subject: [jira] [Commented] (LOG4J2-1593) Concrete Filter implementations
 should override equals and hashCode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 19 Sep 2016 08:44:22 -0000


    [ https://issues.apache.org/jira/browse/LOG4J2-1593?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D155=
02737#comment-15502737 ]=20

Mikael St=C3=A5ldal commented on LOG4J2-1593:
----------------------------------------

OK, given the current implementation of the filter framework, it seems to b=
e necessary. Just make sure to document that third-party Filters need to do=
 it.

> Concrete Filter implementations should override equals and hashCode
> -------------------------------------------------------------------
>
>                 Key: LOG4J2-1593
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1593
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Filters
>            Reporter: Remko Popma
>             Fix For: 2.8
>
>
> For {{CompositeFilter.remove(Filter)}} to work correctly, concrete Filter=
 implementations should override {{equals}} and {{hashCode}}.=20
> This is because CompositeFilter uses List.remove(Object), comparing by eq=
uality. Applications that keep a reference to the Filter object that was re=
gistered will work, but for example registering and unregistering serialize=
d and deserialized instances via JMX will not work without this.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org