Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EEE09200B8A for ; Sat, 24 Sep 2016 23:56:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ED56C160AD1; Sat, 24 Sep 2016 21:56:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BAC04160AC2 for ; Sat, 24 Sep 2016 23:56:06 +0200 (CEST) Received: (qmail 12981 invoked by uid 500); 24 Sep 2016 21:56:05 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 12970 invoked by uid 99); 24 Sep 2016 21:56:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Sep 2016 21:56:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 715261A01F7 for ; Sat, 24 Sep 2016 21:56:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.898 X-Spam-Level: * X-Spam-Status: No, score=1.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Zk9goH2PMlbr for ; Sat, 24 Sep 2016 21:56:03 +0000 (UTC) Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4C7735F366 for ; Sat, 24 Sep 2016 21:56:02 +0000 (UTC) Received: by mail-oi0-f47.google.com with SMTP id t83so171216334oie.3 for ; Sat, 24 Sep 2016 14:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=cmyCxztP67pf2Fo+P+yI2BKX4txq4CkNyVH+6sEcagE=; b=hA8tKLbSSarc2rSov5jg4tLE6E0/d6mOoM6ud7RwHIxK6GPLQxSYY7O+IfhCUz/cf8 GNK8HgvJ26IlILxTKVYjBZS3M/9NB1z0pY7ImWP/ao/subgH8eeGNWvWAEyd/bb+Pbfm mpkhKAuxAdDrLugE9PyPyW0dq9NLr7moxcejTrOwfiIx//tfsz8B46serGawrRYgWUze jDkecGHJJ39skclHWVhdrFThPIfF16GY9lrGz3NTTffxKBymFxvmzIAIPiPlIQtwFb6K e/JXnMO+Ix+MVBLoRc5pPta2Pgw58elpL/W/TfIWvd94/yKpXrYMjQ+iIM8wo15Fcd29 v5hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=cmyCxztP67pf2Fo+P+yI2BKX4txq4CkNyVH+6sEcagE=; b=egigd4aZ5QXJUAGaYgn0Xfq7op/jgSwIErrgazIWfPSbwCEyFnhiPmpFcA3ocBZXj5 dgwlUrREE2c3qg6d9DHnqDYrQzvH/oIP7atsUoJmhPe/It0rigX7CWfYAnqWGDLXqPap BaZHfEE2xGiapPu+i1gOBgQz8OFXPatQUXPGhvtdWrdvcKEjUMZ+a8ClnxKk7RT28aQk cJ3sbiLGUC3TyLafGC9cFVlzCiSCZh3LCnvy0LF7FQgxm5H0r1bquhIleEtCLQq2y8pF UUwCxbHZqLawkF7YVMoIEmFj8/n75aViW2245y8I5L5R7Vrj3Vo3XOctVuSMqQrNhEVR vX3A== X-Gm-Message-State: AE9vXwN9Dsjm/ckJFEF/Vbj1Z8Gb1JPCfSE55rnPv5RYk8k1pahdsVoKPdx+/XO3NQ0KZs3U3We8hvRMrLTJZg== X-Received: by 10.202.98.130 with SMTP id w124mr19361336oib.148.1474754154799; Sat, 24 Sep 2016 14:55:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.40.122 with HTTP; Sat, 24 Sep 2016 14:55:54 -0700 (PDT) In-Reply-To: References: <6D1EA4C1-21D9-466B-A85B-16308202CD85@dslextreme.com> From: Gary Gregory Date: Sat, 24 Sep 2016 14:55:54 -0700 Message-ID: Subject: Re: Build fails To: Log4J Developers List Content-Type: multipart/alternative; boundary=001a113d307e8729e6053d47f54d archived-at: Sat, 24 Sep 2016 21:56:08 -0000 --001a113d307e8729e6053d47f54d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable All tests now pass on my machine. Gary On Sat, Sep 24, 2016 at 10:44 AM, Remko Popma wrote= : > The log4j-core tests now pass on my machine. > The log4j-1.2-api tests fail, specifically Log4j1ConfigurationConverterH= adoopTest > and Log4j1ConfigurationConverterSparkTest. > > On Sun, Sep 25, 2016 at 1:47 AM, Remko Popma > wrote: > >> My fault. I just committed a fix for that. This test now passes in my >> IDE. Still running the full build (but that takes ~20 minutes...) >> >> On Sun, Sep 25, 2016 at 1:22 AM, Gary Gregory >> wrote: >> >>> Hm, is I am seeing: >>> >>> Failed tests: >>> AsyncLoggerConfigAllThreadContextImplementationsTest.testAsy >>> ncLogWritesToLog:142->checkResult:159 SynchronousContextTest.log: line >>> 0 expected:<...mapvalue, configProp[=3DconfigValue, >>> configProp2=3DconfigValue2]} WEBAPP DefaultThre...> but was:<...mapva >>> lue, configProp[2=3DconfigValue2, configProp=3DconfigValue]} WEBAPP >>> DefaultThre...> >>> AsyncLoggerConfigAllThreadContextImplementationsTest.testAsy >>> ncLogWritesToLog:142->checkResult:159 SynchronousContextTest.log: line >>> 0 expected:<...mapvalue, configProp[=3DconfigValue, >>> configProp2=3DconfigValue2]} GARBAGE_FREE Garba...> but was:<...mapva >>> lue, configProp[2=3DconfigValue2, configProp=3DconfigValue]} GARBAGE_FR= EE >>> Garba...> >>> AsyncLoggerConfigAllThreadContextImplementationsTest.testAsy >>> ncLogWritesToLog:142->checkResult:159 SynchronousContextTest.log: line >>> 0 expected:<...mapvalue, configProp[=3DconfigValue, >>> configProp2=3DconfigValue2]} COPY_ON_WRITE Copy...> but was:<...mapva >>> lue, configProp[2=3DconfigValue2, configProp=3DconfigValue]} COPY_ON_WR= ITE >>> Copy...> >>> >>> Tests run: 1469, Failures: 3, Errors: 0, Skipped: 32 >>> >>> Gary >>> >>> On Sat, Sep 24, 2016 at 9:17 AM, Gary Gregory >>> wrote: >>> >>>> The HTML output happens in org.apache.log4j.config.Log >>>> 4j1ConfigurationFactoryTest.testConsole(String) because the >>>> configuration is started and stopped. I do not see how to avoid this s= ince >>>> we are testing that the Console Appender is configured with an HTML la= yout. >>>> >>>> Gary >>>> >>>> On Sat, Sep 24, 2016 at 12:30 AM, Ralph Goers < >>>> ralph.goers@dslextreme.com> wrote: >>>> >>>>> What=E2=80=99s done? CategoryTest is still not working properly. Hea= ded to >>>>> sleep now. I hope to try to do a release when you get this fixed. >>>>> >>>>> Ralph >>>>> >>>>> On Sep 23, 2016, at 11:35 PM, Gary Gregory >>>>> wrote: >>>>> >>>>> Looks like you already changed the file to output to a file instead o= f >>>>> the console... done then. >>>>> >>>>> Gary >>>>> >>>>> On Fri, Sep 23, 2016 at 11:07 PM, Gary Gregory >>>> > wrote: >>>>> >>>>>> I'm fixing... sorry about that. >>>>>> >>>>>> On Fri, Sep 23, 2016 at 10:35 PM, Ralph Goers < >>>>>> ralph.goers@dslextreme.com> wrote: >>>>>> >>>>>>> Gary, >>>>>>> >>>>>>> Why are you checking in stuff that doesn=E2=80=99t build? Jenkins = failed >>>>>>> with bad imports and now several unit tests are failing. Please do= n=E2=80=99t >>>>>>> check in stuff that doesn=E2=80=99t work. Once again I won=E2=80= =99t be able to start the >>>>>>> release process. >>>>>>> >>>>>>> Ralph >>>>>>> >>>>>>> ------------------------------------------------------------ >>>>>>> --------- >>>>>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org >>>>>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>>>> Java Persistence with Hibernate, Second Edition >>>>>> >>>>>> JUnit in Action, Second Edition >>>>>> Spring Batch in Action >>>>>> Blog: http://garygregory.wordpress.com >>>>>> Home: http://garygregory.com/ >>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>>> Java Persistence with Hibernate, Second Edition >>>>> >>>>> JUnit in Action, Second Edition >>>>> Spring Batch in Action >>>>> Blog: http://garygregory.wordpress.com >>>>> Home: http://garygregory.com/ >>>>> Tweet! http://twitter.com/GaryGregory >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>> Java Persistence with Hibernate, Second Edition >>>> >>>> JUnit in Action, Second Edition >>>> Spring Batch in Action >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> >>> -- >>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>> Java Persistence with Hibernate, Second Edition >>> >>> JUnit in Action, Second Edition >>> Spring Batch in Action >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >> >> > --=20 E-Mail: garydgregory@gmail.com | ggregory@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --001a113d307e8729e6053d47f54d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
All=C2=A0tests now pass o= n my machine.=C2=A0

=
Gary

On Sat, Sep 24, 2016 at 1= 0:44 AM, Remko Popma <remko.popma@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
The log4j-core tests now pas= s on my machine.
The log4j-1.2-api tests fail, specifically =C2=A0= Log4j1ConfigurationConverterHadoopTest and=C2=A0Log4j1Configurati= onConverterSparkTest.

On Sun, Sep 25= , 2016 at 1:47 AM, Remko Popma <remko.popma@gmail.com> w= rote:
My fault. I just c= ommitted a fix for that. This test now passes in my IDE. Still running the = full build (but that takes ~20 minutes...)

On Sun, Sep 25, 2016 at 1:22 AM, G= ary Gregory <garydgregory@gmail.com> wrote:
Hm, is I am seeing:

<= div>
Failed tests:
=C2=A0 AsyncLoggerConfigAllThreadCont= extImplementationsTest.testAsyncLogWritesToLog:142->checkResul= t:159 SynchronousContextTest.log: line 0 expected:<...mapvalue, configPr= op[=3DconfigValue, configProp2=3DconfigValue2]} WEBAPP DefaultThre...> b= ut was:<...mapva
lue, configProp[2=3DconfigValue2, configProp= =3DconfigValue]} WEBAPP DefaultThre...>
=C2=A0 AsyncLoggerConf= igAllThreadContextImplementationsTest.testAsyncLogWritesToLog:142= ->checkResult:159 SynchronousContextTest.log: line 0 expected:<.= ..mapvalue, configProp[=3DconfigValue, configProp2=3DconfigValue2]} GARBAGE= _FREE Garba...> but was:<...mapva
lue, configProp[2=3Dconfi= gValue2, configProp=3DconfigValue]} GARBAGE_FREE Garba...>
=C2= =A0 AsyncLoggerConfigAllThreadContextImplementationsTest.testAsyn= cLogWritesToLog:142->checkResult:159 SynchronousContextTest.log: li= ne 0 expected:<...mapvalue, configProp[=3DconfigValue, configProp2=3Dcon= figValue2]} COPY_ON_WRITE Copy...> but was:<...mapva
lue, c= onfigProp[2=3DconfigValue2, configProp=3DconfigValue]} COPY_ON_WRITE Copy..= .>

Tests run: 1469, Failures: 3, Errors: 0, Ski= pped: 32

Gary<= /div>

On Sat, Sep 24, 2016 at 9:17 AM, Gary Gregory <ga= rydgregory@gmail.com> wrote:
The HTML output happens in=C2=A0org.apache.log4j.config.= Log4j1ConfigurationFactoryTest.testConsole(String) because the co= nfiguration is started and stopped. I do not see how to avoid this since we= are testing that the Console Appender is configured with an HTML layout.

Gary

On S= at, Sep 24, 2016 at 12:30 AM, Ralph Goers <ralph.goers@dslextreme= .com> wrote:
What=E2=80=99s done? CategoryTest is still not w= orking properly.=C2=A0 Headed to sleep now. I hope to try to do a release w= hen you get this fixed.

Ralph

On Sep 23, 2016, at 11:35 PM, Gary Gregory <garydgregory@gmail= .com> wrote:

Looks like you already c= hanged the file to output to a file instead of the console... done then.
Gary

On Fri, Sep 23, 2016 at 11:07 PM, Gary Gregory <ga= rydgregory@gmail.com> wrote:
I'm fixing... sorry about that.

On Fri, Sep 23, 2016 a= t 10:35 PM, Ralph Goers <ralph.goers@dslextreme.com> wrote:
Gary,

Why are you checking in stuff that doesn=E2=80=99t build?=C2=A0 Jenkins fai= led with bad imports and now several unit tests are failing.=C2=A0 Please d= on=E2=80=99t check in stuff that doesn=E2=80=99t work.=C2=A0 Once again I w= on=E2=80=99t be able to start the release process.

Ralph

-----------------------------------------------------------------= ----
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org




--



--




--



--
=





--
=
--001a113d307e8729e6053d47f54d--