Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
MIME-Version: 1.0
In-Reply-To: <CACZkXPyN8PDfNcN2gALH5WGxdr8CS5ZBrL=Pw4ufK=LjvyJXXg@mail.gmail.com>
References: <CACZkXPyN8PDfNcN2gALH5WGxdr8CS5ZBrL=Pw4ufK=LjvyJXXg@mail.gmail.com>
From: Matt Sicker <boards@gmail.com>
Date: Mon, 4 Jul 2016 15:00:45 -0500
Message-ID: <CACmp6ko7coEf3gzVYcOdFhDaEbj7aQ7zigXE2mZd0Qoic-=ioQ@mail.gmail.com>
Subject: Re: Log4j should manage it's own threads
To: Log4J Developers List <log4j-dev@logging.apache.org>
Content-Type: multipart/alternative; boundary=94eb2c03d9a6c0cd510536d4ca41
archived-at: Mon, 04 Jul 2016 20:00:52 -0000

--94eb2c03d9a6c0cd510536d4ca41
Content-Type: text/plain; charset=UTF-8

This sounds like an interesting idea worth pursuing.

On 4 July 2016 at 14:56, Gary Gregory <garydgregory@gmail.com> wrote:

> When I see code like:
>
>                     LOGGER.debug("RollingFileManager executing async {}",
> descriptor.getAsynchronous());
>                     thread = new Log4jThread(new
> AsyncAction(descriptor.getAsynchronous(), this));
>                     thread.start();
>
> and:
>
>             final Thread thread = new Log4jThread(new
> ReconfigurationWorker(listener, reconfigurable));
>             thread.setDaemon(true);
>             thread.start();
>
> and other places, I think: "and poof, I've lost track of that thread".
>
> What if we used a thread pool (ExecutorService) to track all of our
> threads? This would allow for at least trying for an orderly shutdown. This
> would avoid problems like one part of an app thinking that rollovers should
> be done when they are not because a log4j context has been stopped (like in
> our test probably) but the rollover thread is still going about doing its
> work.
>
> This would be for 2.7 I think.
>
> We could then have a different context stop API, maybe with a timeout or
> not, something like ExecutorService's shutdown() vs. shutdownNow().
>
> Thoughts?
>
> Happy 4th!
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>


-- 
Matt Sicker <boards@gmail.com>

--94eb2c03d9a6c0cd510536d4ca41
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">This sounds like an interesting idea worth pursuing.</div>=
<div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On 4 July 2016 at=
 14:56, Gary Gregory <span dir=3D"ltr">&lt;<a href=3D"mailto:garydgregory@g=
mail.com" target=3D"_blank">garydgregory@gmail.com</a>&gt;</span> wrote:<br=
><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1=
px #ccc solid;padding-left:1ex"><div dir=3D"ltr">When I see code like:<div>=
<br></div><div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 LOGGER.debug(&quot;RollingFileManager executing async {}&quo=
t;, descriptor.getAsynchronous());</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 thread =3D new Log4jThread(new As=
yncAction(descriptor.getAsynchronous(), this));</div><div>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 thread.start();</div><=
div><br></div><div>and:</div><div><br></div><div><div>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 final Thread thread =3D new Log4jThread(new Reconfigur=
ationWorker(listener, reconfigurable));</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 thread.setDaemon(true);</div><div>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 thread.start();</div></div><div><br></div><div>and oth=
er places, I think: &quot;and poof, I&#39;ve lost track of that thread&quot=
;.</div><div><br></div><div>What if we used a thread pool (ExecutorService)=
 to track all of our threads? This would allow for at least trying for an o=
rderly shutdown. This would avoid problems like one part of an app thinking=
 that rollovers should be done when they are not because a log4j context ha=
s been stopped (like in our test probably) but the rollover thread is still=
 going about doing its work.</div><div><br></div><div>This would be for 2.7=
 I think.</div><div><br></div><div>We could then have a different context s=
top API, maybe with a timeout or not, something like=C2=A0ExecutorService&#=
39;s shutdown() vs. shutdownNow().</div><div><br></div><div>Thoughts?</div>=
<div><br></div><div>Happy 4th!</div><span class=3D"HOEnZb"><font color=3D"#=
888888"><div><br></div><div>Gary</div><div><br></div>-- <br><div data-smart=
mail=3D"gmail_signature"><div dir=3D"ltr">E-Mail: <a href=3D"mailto:garydgr=
egory@gmail.com" target=3D"_blank">garydgregory@gmail.com</a> | <a href=3D"=
mailto:ggregory@apache.org" target=3D"_blank">ggregory@apache.org </a><br><=
a href=3D"http://www.manning.com/bauer3/" target=3D"_blank">Java Persistenc=
e with Hibernate, Second Edition</a><br><a href=3D"http://www.manning.com/t=
ahchiev/" target=3D"_blank">JUnit in Action, Second Edition</a><br><a href=
=3D"http://www.manning.com/templier/" target=3D"_blank">Spring Batch in Act=
ion</a><br>Blog: <a href=3D"http://garygregory.wordpress.com/" target=3D"_b=
lank">http://garygregory.wordpress.com</a> <br>Home: <a href=3D"http://gary=
gregory.com/" target=3D"_blank">http://garygregory.com/</a><br>Tweet! <a hr=
ef=3D"http://twitter.com/GaryGregory" target=3D"_blank">http://twitter.com/=
GaryGregory</a></div></div>
</font></span></div></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
=3D"gmail_signature" data-smartmail=3D"gmail_signature">Matt Sicker &lt;<a =
href=3D"mailto:boards@gmail.com" target=3D"_blank">boards@gmail.com</a>&gt;=
</div>
</div>

--94eb2c03d9a6c0cd510536d4ca41--