logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: Merging github pull requests
Date Sun, 31 Jul 2016 11:38:28 GMT
Thanks guys!

Sent from my iPhone

> On 2016/07/31, at 2:01, Matt Sicker <boards@gmail.com> wrote:
> 
> On the initial pull request, the sent email has the git commands to pull it Ito your
own git repo. You can also just turn it into a patch file like Gary mentioned, too.
> 
> On Saturday, 30 July 2016, Gary Gregory <garydgregory@gmail.com> wrote:
>> Try adding ".patch" or ".diff" to the github URL
>> 
>> 
>>> On Jul 30, 2016 4:50 AM, "Remko Popma" <remko.popma@gmail.com> wrote:
>>> Does anyone have experience merging Github pull requests into Log4j2?
>>> The pull requests are based on the github.com mirror of the git.apache.org repository
so a lot of the instructions don't make sense to me.
>>> 
>>> I want to work on https://github.com/apache/logging-log4j2/pull/34 but don't
know how to make progress. I would be okay with creating a patch and merging that but I cannot
fin a way to do this from the github.com web interface.
>>> 
>>> Remko
> 
> 
> -- 
> Matt Sicker <boards@gmail.com>

Mime
View raw message