logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1453) Configurable shutdown timeout for AsyncLogger
Date Thu, 30 Jun 2016 21:59:10 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357929#comment-15357929
] 

Gary Gregory commented on LOG4J2-1453:
--------------------------------------

And yes, Duration is perfect for that.

> Configurable shutdown timeout for AsyncLogger
> ---------------------------------------------
>
>                 Key: LOG4J2-1453
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1453
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.6.1
>            Reporter: David Leonhartsberger
>            Priority: Minor
>   Original Estimate: 28h
>  Remaining Estimate: 28h
>
> The current implementation of {code}AsyncLoggerDisruptor#stop(){code} could block for
a long time waiting for the Disruptor queue to be processed.
> I suggest to use a configurable timeout (similar to AsyncAppender) and call the {code}Disruptor#shutdown(final
long timeout, final TimeUnit timeUnit){code} method instead of the one which takes no paramter
and therefore waits indefinitely. 
> If there are still unconsumed log entries left in the Disruptor after the timeout, I
would just log the count of discarded entries as its done in AsyncAppender.stop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message