logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: logging-log4j2 git commit: Revert "Make fairness configurable in ArrayBlockingQueueFactory"
Date Sat, 18 Jun 2016 02:17:37 GMT
Thanks!

Sent from my iPhone

> On 2016/06/18, at 11:11, mattsicker@apache.org wrote:
> 
> Repository: logging-log4j2
> Updated Branches:
>  refs/heads/feature/LOG4J2-1430 bf997fc10 -> 604306cc8
> 
> 
> Revert "Make fairness configurable in ArrayBlockingQueueFactory"
> 
> This reverts commit bf997fc1007e70a526bb20b6c90e63202c6f0886.
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/604306cc
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/604306cc
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/604306cc
> 
> Branch: refs/heads/feature/LOG4J2-1430
> Commit: 604306cc8bf3cea8fa9821218dcefc5c1760f75b
> Parents: bf997fc
> Author: Matt Sicker <boards@gmail.com>
> Authored: Fri Jun 17 21:11:22 2016 -0500
> Committer: Matt Sicker <boards@gmail.com>
> Committed: Fri Jun 17 21:11:22 2016 -0500
> 
> ----------------------------------------------------------------------
> .../log4j/core/async/ArrayBlockingQueueFactory.java   | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/604306cc/log4j-core/src/main/java/org/apache/logging/log4j/core/async/ArrayBlockingQueueFactory.java
> ----------------------------------------------------------------------
> diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/async/ArrayBlockingQueueFactory.java
b/log4j-core/src/main/java/org/apache/logging/log4j/core/async/ArrayBlockingQueueFactory.java
> index ef1f05d..dcad78a 100644
> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/async/ArrayBlockingQueueFactory.java
> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/async/ArrayBlockingQueueFactory.java
> @@ -5,7 +5,6 @@ import java.util.concurrent.BlockingQueue;
> 
> import org.apache.logging.log4j.core.config.Node;
> import org.apache.logging.log4j.core.config.plugins.Plugin;
> -import org.apache.logging.log4j.core.config.plugins.PluginAttribute;
> import org.apache.logging.log4j.core.config.plugins.PluginFactory;
> 
> /**
> @@ -15,20 +14,13 @@ import org.apache.logging.log4j.core.config.plugins.PluginFactory;
>  */
> @Plugin(name = "ArrayBlockingQueue", category = Node.CATEGORY, elementType = BlockingQueueFactory.ELEMENT_TYPE)
> public class ArrayBlockingQueueFactory<E> implements BlockingQueueFactory<E>
{
> -
> -    private final boolean fair;
> -
> -    private ArrayBlockingQueueFactory(final boolean fair) {
> -        this.fair = fair;
> -    }
> -
>     @Override
>     public BlockingQueue<E> create(int capacity) {
> -        return new ArrayBlockingQueue<>(capacity, fair);
> +        return new ArrayBlockingQueue<>(capacity);
>     }
> 
>     @PluginFactory
> -    public static <E> ArrayBlockingQueueFactory<E> createFactory(@PluginAttribute("fair")
final boolean fair) {
> -        return new ArrayBlockingQueueFactory<>(fair);
> +    public static <E> ArrayBlockingQueueFactory<E> createFactory() {
> +        return new ArrayBlockingQueueFactory<>();
>     }
> }
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message