logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: CharSequence messages
Date Fri, 03 Jun 2016 11:49:21 GMT
I don't see any problem with that. 
Let's make a similar change then also in ReusableMessageFactory. 

Sent from my iPhone

> On 2016/06/03, at 19:49, Mikael Ståldal <mikael.staldal@magine.com> wrote:
> 
> Would it make sense if AbstractMessageFactory was changed so that this method:
> @Override
> public Message newMessage(final Object message) {
>     return new ObjectMessage(message);
> }
> did this:
> @Override
> public Message newMessage(final Object message) {
>     if (message instanceof CharSequence) {
>         return new SimpleMessage((CharSequence) message)
>     } else {
>         return new ObjectMessage(message);
>     }
> }
> 
> -- 
>  
> 
> Mikael Ståldal
> Senior software developer 
> 
> Magine TV
> mikael.staldal@magine.com    
> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com             
> 
> Privileged and/or Confidential Information may be contained in this message. If you are
not the addressee indicated in this message
> (or responsible for delivery of the message to such a person), you may not copy or deliver
this message to anyone. In such case, 
> you should destroy this message and kindly notify the sender by reply email.   

Mime
View raw message