logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Niggemann (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LOG4J2-1376) RFC5424 Enterprise Number should be an OID fragment.
Date Mon, 02 May 2016 21:09:12 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267512#comment-15267512
] 

Mark Niggemann edited comment on LOG4J2-1376 at 5/2/16 9:09 PM:
----------------------------------------------------------------

Enterprise number should be a string, but it should represent an OID pattern. That is, it
should match a pattern "([1-9][0-9]*\\\\.)*[1-9][0-9]*". The important part of the pattern
match is that OIDs are integers separated by '.' and you may not use leading zeros on any
integer. 

Furthermore, if someone were configure the layout to give a fully qualified value the IANA
prefix (1.3.6.1.4.1.) along with the enterprise number, you would strip that off and use only
the suffix in any non-standard StructuredDataId. 

Of course, the fun part is that the entire ID must be no longer than 32 characters in length.
For example, if you have enterprise number of 22005.42.1.21 (which is 13 characters long in
US-ASCII), your message id (excluding the '@' character) can only be 18 characters long. I'm
not really sure how to verify this is the case ahead of time when the message is created,
since the layout is decoupled from the log call.


was (Author: niggemannmj):
Enterprise number should be a string, but it should represent an OID pattern. That is, it
should match a pattern "([1-9][0-9]*\\.)*[1-9][0-9]*". The important part of the pattern match
is that OIDs are integers separated by '.' and you may not use leading zeros on any integer.


Furthermore, if someone were configure the layout to give a fully qualified value the IANA
prefix (1.3.6.1.4.1.) along with the enterprise number, you would strip that off and use only
the suffix in any non-standard StructuredDataId. 

Of course, the fun part is that the entire ID must be no longer than 32 characters in length.
For example, if you have enterprise number of 22005.42.1.21 (which is 13 characters long in
US-ASCII), your message id (excluding the '@' character) can only be 18 characters long. I'm
not really sure how to verify this is the case ahead of time when the message is created,
since the layout is decoupled from the log call.

> RFC5424 Enterprise Number should be an OID fragment.
> ----------------------------------------------------
>
>                 Key: LOG4J2-1376
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1376
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core, Layouts
>    Affects Versions: 2.5
>            Reporter: Mark Niggemann
>
> Rfc5424Layout incorrectly implements the Enterprise Number as a simple integer value
for StructuredDataId types that are not assigned by IANA. 
> This is incorrect according to RFC5424. The implementation should allow for this to be
an OID fragment representing the private enterprise subtree which is interpreted as the suffix
to the IANA SMI Network Management Private Enterprise Code prefix 1.3.6.1.4.1. Refer to RFC5424,
section 7.2.2. 
> For example, GE Healthcare IT has IANA private enterprise number 22005 and there are
several other systems we support that are hierarchically assigned subtree OID fragments. Ordinarily,
these codes would have the following form: 1.3.6.1.4.1.22005.<subtree-oid>. RFC5424
allows for truncating the SMI prefix and leaving the private enterprise number subtree in
the message. So they would appear as 22005.<subtree-oid> (e.g., 22005.42.1.21).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message