logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: The LOG4J2-1347 branch
Date Wed, 04 May 2016 17:05:43 GMT
Cool. Any idea how that affects speed or memory? Does it matter?

Gary
On May 4, 2016 8:59 AM, "Remko Popma" <remko.popma@gmail.com> wrote:

> I reviewed the LOG4J2-1347 branch and I like the work Mikael did here. Replacing
> the deserialize(serialize(logevent)) sequences with
> Log4jLogEvent.createMemento() looks cleaner.
>
> I could not see any issue and I don't mind if these changes are merged
> into master.
>
> (Implementing the feature requested in LOG4J2-1347 is a separate thing and
> will require more work.)
>
> Remko
>

Mime
View raw message