logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: org.apache.logging.log4j.util.Unbox.isBoxedPrimitive(StringBuilder)
Date Fri, 27 May 2016 01:32:54 GMT
There are no callers of the method within Log4j ATM.

Gary

On Thu, May 26, 2016 at 6:20 PM, Remko Popma <remko.popma@gmail.com> wrote:

> Where is this method used?
> It is intended to allow the caller to find out if the specified
> StringBuilder instance is managed by Unbox.
>
> Sent from my iPhone
>
> On 2016/05/27, at 9:50, Gary Gregory <garydgregory@gmail.com> wrote:
>
> Ok, so let's drop it from master. I'm AFK ATM.
>
> Gary
> On May 26, 2016 12:26 PM, "Matt Sicker" <boards@gmail.com> wrote:
>
>> Most of the classes in that package start with the italicized words *Consider
>> this class private.*
>>
>> On 26 May 2016 at 14:19, Gary Gregory <garydgregory@gmail.com> wrote:
>>
>>> On Thu, May 26, 2016 at 11:36 AM, Matt Sicker <boards@gmail.com> wrote:
>>>
>>>> Everything in that util package is log4j-private, so there's no worries
>>>> about removing things.
>>>>
>>>
>>> Ah, yes, now I see:
>>>
>>> "Internal utility classes for the Log4j 2 API. Note that the use of any
>>> classes in this package is not supported. There are no guarantees for
>>> binary or logical compatibility in this package."
>>>
>>> I wonder if we should *bold* some of that text.
>>>
>>> Gary
>>>
>>>
>>>>
>>>> On 26 May 2016 at 12:13, Gary Gregory <garydgregory@gmail.com> wrote:
>>>>
>>>>> The method:
>>>>>
>>>>> org.apache.logging.log4j.util.Unbox.isBoxedPrimitive(StringBuilder)
>>>>>
>>>>> is unused and undocumented. Can we drop it?
>>>>>
>>>>> I guess it's already in the 2.6 RC1, which is too bad.
>>>>>
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <boards@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> Matt Sicker <boards@gmail.com>
>>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message