Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Date: Tue, 5 Apr 2016 15:04:25 +0000 (UTC)
From: "Greg Thomas (JIRA)" <jira@apache.org>
To: log4j-dev@logging.apache.org
Message-ID: <JIRA.12955331.1459524875000.139089.1459868665555@Atlassian.JIRA>
In-Reply-To: <JIRA.12955331.1459524875000@Atlassian.JIRA>
References: <JIRA.12955331.1459524875000@Atlassian.JIRA>
 <JIRA.12955331.1459524875388@arcas>
Subject: [jira] [Commented] (LOG4J2-1348) Add an AutoCloseable ThreadContext
 class: CloseableThreadContext
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LOG4J2-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226415#comment-15226415 ] 

Greg Thomas commented on LOG4J2-1348:
-------------------------------------

The static method can't return `this` - but there's no reason why `put(...)` / `push(...)` couldn't be instance methods as well as static methods. Something like

{code}
public static put(String key, String value) {
    return new CloseableThreadContext().put(key, value);
}

public CloseableThreadContext put(String key, String value) {
    ...
    return this;
}
{code}

However, this still requires new object creation, hence requiring garbage collection.

> Add an AutoCloseable ThreadContext class: CloseableThreadContext
> ----------------------------------------------------------------
>
>                 Key: LOG4J2-1348
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1348
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>            Reporter: Greg Thomas
>            Assignee: Gary Gregory
>            Priority: Minor
>             Fix For: 2.6
>
>         Attachments: CloseableThreadContext.zip, thread-context.xml.patch
>
>
> The log4j2 API provides a ThreadContext - https://logging.apache.org/log4j/2.x/manual/thread-context.html -  that allows items to be added to a stack or a map for logging, and then subsequently removed once they are no longer required.
> This sounds like an ideal candidate for a AutoCloseable implementation so that items are removed automatically and no longer left around littering the stack/map.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org