logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remko Popma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1329) API change: let Message.getFormattedMessage() return CharSequence instead of String
Date Wed, 30 Mar 2016 12:03:25 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217855#comment-15217855
] 

Remko Popma commented on LOG4J2-1329:
-------------------------------------

I think that may be the way to go for now. We can always optimize further later to avoid unnecessary
copying. 

By the way, the GcFreeLoggingTest in the LOG4J2-1278-gc-free-logger branch currently fails
because GelfLayout delegates to a 3rd party library that allocates temp objects. (Maybe Jackson.)
Can you take a look?

> API change: let Message.getFormattedMessage() return CharSequence instead of String
> -----------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1329
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1329
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 2.5
>            Reporter: Remko Popma
>
> I propose that we change {{Message.getFormattedMessage()}} to return a {{CharSequence}}
instead of a String.
> I believe this change would be backwards compatible (all Message implementations that
return a String will work as is), and it opens the way
> for zero-GC Message implementations to return a cached StringBuilder as Mikael [suggested
on the log4j-dev mailing list|http://mail-archives.apache.org/mod_mbox/logging-log4j-dev/201603.mbox/%3CCAAFrFhSs4EqjOERwHObKAZP4wjGWeiCET1nyE1FVndYdePk2yw%40mail.gmail.com%3E].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message