Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
From: Remko Popma <remko.popma@gmail.com>
Content-Type: multipart/alternative;
	boundary=Apple-Mail-CD729C08-6095-4467-ACBC-7EB8F5475E9F
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Subject: Re: traceExit and auto-boxing
Message-Id: <59594147-6DA5-4870-BFE1-CBB5841E18B5@gmail.com>
Date: Tue, 16 Feb 2016 08:46:55 +0900
References: 
 <CACZkXPw11QmEP3skEkY=yHO8f92UxFyz5kZC1C2po-SOAdG7SQ@mail.gmail.com>
 <CACmp6kqW_tckbu8QwaqRNr=Kgt5W4-Liaozi6ZZ_j2SPCO4+Eg@mail.gmail.com>
In-Reply-To: 
 <CACmp6kqW_tckbu8QwaqRNr=Kgt5W4-Liaozi6ZZ_j2SPCO4+Eg@mail.gmail.com>
To: Log4J Developers List <log4j-dev@logging.apache.org>

--Apple-Mail-CD729C08-6095-4467-ACBC-7EB8F5475E9F
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable

A word of caution: the Logger API already has 209 method (and I think a few j=
ust got added). This will explode if we just add "var-arg unrolling" methods=
 for 1 param, 2 params, 3 params, ...  (up to how many?) Especially if we wa=
nt to also prevent auto boxing in all possible combinations of the primitive=
 types boolean, long and double.=20

There may be other ways to accomplish this. Let's think about this a bit lon=
ger. I'll add a Jira for this in the no-GC epic. =20

Sent from my iPhone

> On 2016/02/16, at 1:59, Matt Sicker <boards@gmail.com> wrote:
>=20
> Considering the garbage-free epic, this sounds like a good idea to bake in=
 from the start.
>=20
>> On 15 February 2016 at 10:39, Gary Gregory <garydgregory@gmail.com> wrote=
:
>> Hi All:
>>=20
>> My my custom flow logger, I avoid auto-boxing on traceExit() calls by hav=
ing primitive versions of the APIs. We could do the same and avoid auto-boxi=
ng unless a logger's level is enabled.
>>=20
>> This generates a lot less garbage when, for example, we flow trace our JD=
BC APIs and get 50m rows and 50 columns per row.
>>=20
>> Thoughts?
>>=20
>> Gary
>>=20
>> --=20
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org=20
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com=20
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>=20
>=20
>=20
> --=20
> Matt Sicker <boards@gmail.com>

--Apple-Mail-CD729C08-6095-4467-ACBC-7EB8F5475E9F
Content-Type: text/html;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div>A word of caution: the Logger API alre=
ady has 209 method (and I think a few just got added). This will explode if w=
e just add "var-arg unrolling" methods for 1 param, 2 params, 3 params, ... &=
nbsp;(up to how many?) Especially if we want to also prevent auto boxing in a=
ll possible combinations of the primitive types boolean, long and double.&nb=
sp;</div><div id=3D"AppleMailSignature"><br></div><div id=3D"AppleMailSignat=
ure">There may be other ways to accomplish this. Let's think about this a bi=
t longer. I'll add a Jira for this in the no-GC epic. &nbsp;<br><br>Sent fro=
m my iPhone</div><div><br>On 2016/02/16, at 1:59, Matt Sicker &lt;<a href=3D=
"mailto:boards@gmail.com">boards@gmail.com</a>&gt; wrote:<br><br></div><bloc=
kquote type=3D"cite"><div><div dir=3D"ltr">Considering the garbage-free epic=
, this sounds like a good idea to bake in from the start.</div><div class=3D=
"gmail_extra"><br><div class=3D"gmail_quote">On 15 February 2016 at 10:39, G=
ary Gregory <span dir=3D"ltr">&lt;<a href=3D"mailto:garydgregory@gmail.com" t=
arget=3D"_blank">garydgregory@gmail.com</a>&gt;</span> wrote:<br><blockquote=
 class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid=
;padding-left:1ex"><div dir=3D"ltr">Hi All:<div><br></div><div>My my custom f=
low logger, I avoid auto-boxing on traceExit() calls by having primitive ver=
sions of the APIs. We could do the same and avoid auto-boxing unless a logge=
r's level is enabled.</div><div><br></div><div>This generates a lot less gar=
bage when, for example, we flow trace our JDBC APIs and get 50m rows and 50 c=
olumns per row.</div><div><br></div><div>Thoughts?</div><span class=3D"HOEnZ=
b"><font color=3D"#888888"><div><br></div><div>Gary<br clear=3D"all"><div><b=
r></div>-- <br><div><div dir=3D"ltr">E-Mail: <a href=3D"mailto:garydgregory@=
gmail.com" target=3D"_blank">garydgregory@gmail.com</a> | <a href=3D"mailto:=
ggregory@apache.org" target=3D"_blank">ggregory@apache.org </a><br><a href=3D=
"http://www.manning.com/bauer3/" target=3D"_blank">Java Persistence with Hib=
ernate, Second Edition</a><br><a href=3D"http://www.manning.com/tahchiev/" t=
arget=3D"_blank">JUnit in Action, Second Edition</a><br><a href=3D"http://ww=
w.manning.com/templier/" target=3D"_blank">Spring Batch in Action</a><br>Blo=
g: <a href=3D"http://garygregory.wordpress.com/" target=3D"_blank">http://ga=
rygregory.wordpress.com</a> <br>Home: <a href=3D"http://garygregory.com/" ta=
rget=3D"_blank">http://garygregory.com/</a><br>Tweet! <a href=3D"http://twit=
ter.com/GaryGregory" target=3D"_blank">http://twitter.com/GaryGregory</a></d=
iv></div>
</div></font></span></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=3D=
"gmail_signature">Matt Sicker &lt;<a href=3D"mailto:boards@gmail.com" target=
=3D"_blank">boards@gmail.com</a>&gt;</div>
</div>
</div></blockquote></body></html>=

--Apple-Mail-CD729C08-6095-4467-ACBC-7EB8F5475E9F--