logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: logging-log4j2 git commit: Refactor words into constants.
Date Sat, 20 Feb 2016 00:42:02 GMT
sure.

G

On Fri, Feb 19, 2016 at 4:23 PM, Remko Popma <remko.popma@gmail.com> wrote:

> What about "default prefix" for "word"?
>
> Sent from my iPhone
>
> > On 2016/02/20, at 9:18, ggregory@apache.org wrote:
> >
> > Repository: logging-log4j2
> > Updated Branches:
> >  refs/heads/master 5e51ae127 -> e0489eb15
> >
> >
> > Refactor words into constants.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e0489eb1
> > Tree:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e0489eb1
> > Diff:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e0489eb1
> >
> > Branch: refs/heads/master
> > Commit: e0489eb1520558b2658f8654257902c0fa768bcb
> > Parents: 5e51ae1
> > Author: ggregory <ggregory@apache.org>
> > Authored: Fri Feb 19 16:18:33 2016 -0800
> > Committer: ggregory <ggregory@apache.org>
> > Committed: Fri Feb 19 16:18:33 2016 -0800
> >
> > ----------------------------------------------------------------------
> > .../logging/log4j/message/DefaultFlowMessageFactory.java       | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e0489eb1/log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java
> > ----------------------------------------------------------------------
> > diff --git
> a/log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java
> b/log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java
> > index c9c2503..a476ca0 100644
> > ---
> a/log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java
> > +++
> b/log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java
> > @@ -24,7 +24,11 @@ import java.io.Serializable;
> >  * @since 2.6
> >  */
> > public class DefaultFlowMessageFactory implements FlowMessageFactory,
> Serializable {
> > +
> > +    private static final String EXIT_WORD = "exit";
> > +    private static final String ENTRY_WORD = "entry";
> >     private static final long serialVersionUID = 8578655591131397576L;
> > +
> >     private final String entryText;
> >     private final String exitText;
> >
> > @@ -32,7 +36,7 @@ public class DefaultFlowMessageFactory implements
> FlowMessageFactory, Serializab
> >      * Constructs a message factory with {@code "entry"} and {@code
> "exit"} as the default flow strings.
> >      */
> >     public DefaultFlowMessageFactory() {
> > -        this("entry", "exit");
> > +        this(ENTRY_WORD, EXIT_WORD);
> >     }
> >
> >     /**
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message