logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (LOG4J2-1260) TlsSyslogFrame calculates message length incorrectly
Date Thu, 21 Jan 2016 22:44:39 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary Gregory closed LOG4J2-1260.
--------------------------------
    Resolution: Fixed

User (Blake) reports all is well with the fix. Closing.

> TlsSyslogFrame calculates message length incorrectly
> ----------------------------------------------------
>
>                 Key: LOG4J2-1260
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1260
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Layouts
>    Affects Versions: 2.5
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>
> TlsSyslogFrame calculates message length incorrectly.
> From the ML https://www.mail-archive.com/log4j-user@logging.apache.org/msg15386.html
> {quote}
> ---------- Forwarded message ----------
> From: Blake Day <blake@chewy.com>
> Date: Wed, Jan 20, 2016 at 4:58 PM
> Subject: TlsSyslogFrame calculates message length incorrectly
> To: Log4J Users List <log4j-user@logging.apache.org>
> TlsSyslogFrame appears to be miscalculating the message length.  According to RFC5425,
the message length must be the octet count of the SYSLOG-MSG in the frame.  Though the variable
below is aptly named messageLengthInBytes, it is assigned the value from message.length()
(where message is a String) rather than the bytes.
> See below for relevant portions of code:
> private String message;
> private int messageLengthInBytes;
> private void setLengthInBytes() {
>     messageLengthInBytes = message.length();
> }
> @Override
> public String toString() {
>     final String length = Integer.toString(messageLengthInBytes);
>     return length + Chars.SPACE + message;
> }
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message