logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: SocketAppender.createAppender() and Protocol Enum
Date Wed, 02 Dec 2015 04:14:13 GMT
I appreciated you want to keep core clean, but if it's easy to avoid breaking BC we should.
We're talking about adding a factory method and calling one factory method from the other.
Isn't that very little effort? Seems worth the effort to be kind to our users. 

Sent from my iPhone

> On 2015/12/02, at 11:17, Gary Gregory <garydgregory@gmail.com> wrote:
> 
> I think I'll not duplicate the create() API, that seems silly. I do not believe we should
provide BC at the level in the Core.
> 
> Gary
> 
>> On Mon, Nov 2, 2015 at 9:47 PM, Gary Gregory <garydgregory@gmail.com> wrote:
>> Sure, that's easy.
>> 
>> Gary
>> 
>>> On Nov 2, 2015 6:39 PM, "Remko Popma" <remko.popma@gmail.com> wrote:
>>> Okay. Can you leave the existing method in place and add a new one with the desired
signature?
>>> 
>>> Sent from my iPhone
>>> 
>>>> On 2015/11/03, at 9:57, Gary Gregory <garydgregory@gmail.com> wrote:
>>>> 
>>>>> On Mon, Nov 2, 2015 at 3:53 PM, Remko Popma <remko.popma@gmail.com>
wrote:
>>>>> What would be the advantage of doing this? What problem are you trying
to solve by replacing the string arg with an enumeration arg?
>>>> 
>>>> Is that a trick question? ;-) Type safety from my call site, of course!
>>>> 
>>>> Gary
>>>> 
>>>>> 
>>>>> 
>>>>>> On Monday, November 2, 2015, Gary Gregory <garydgregory@gmail.com>
wrote:
>>>>>> Hi All:
>>>>>> 
>>>>>> Right now, SocketAppender.createAppender() takes protocol String.
Can we change that to a Protocol Enum safely, without breaking existing configs? That would
break BC unless we add another method. 
>>>>>> 
>>>>>> Thoughts?
>>>>>> 
>>>>>> Gary
>>>>>> 
>>>>>> -- 
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com 
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>> 
>>>> 
>>>> 
>>>> -- 
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com 
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Mime
View raw message