Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C27C18605 for ; Sun, 11 Oct 2015 23:27:59 +0000 (UTC) Received: (qmail 97909 invoked by uid 500); 11 Oct 2015 23:27:59 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 97853 invoked by uid 500); 11 Oct 2015 23:27:59 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 97842 invoked by uid 99); 11 Oct 2015 23:27:59 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Oct 2015 23:27:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C6CD0C059F for ; Sun, 11 Oct 2015 23:27:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.001 X-Spam-Level: *** X-Spam-Status: No, score=3.001 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Riil-thGrsWl for ; Sun, 11 Oct 2015 23:27:49 +0000 (UTC) Received: from smtp679.redcondor.net (smtp679.redcondor.net [208.80.206.79]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id D1ADE20C18 for ; Sun, 11 Oct 2015 23:27:48 +0000 (UTC) Received: from mailproxy11.neonova.net ([137.118.22.76]) by smtp679.redcondor.net ({61e46e34-cfba-43f0-8a4f-f3a481f7eb08}) via TCP (outbound) with ESMTP id 20151011232735783_0679 for ; Sun, 11 Oct 2015 23:27:35 +0000 X-RC-FROM: X-RC-RCPT: Received: from [192.168.1.14] (ip72-201-43-179.ph.ph.cox.net [72.201.43.179]) (Authenticated sender: ralph.goers@dslextreme.com) by mailproxy11.neonova.net (Postfix) with ESMTPA id 28371360056 for ; Sun, 11 Oct 2015 19:27:32 -0400 (EDT) From: Ralph Goers Content-Type: multipart/alternative; boundary="Apple-Mail=_1C5082BE-359E-460F-8739-3B25704AD97E" Message-Id: Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Commit policy question Date: Sun, 11 Oct 2015 16:27:31 -0700 References: <9A75B0E8-614D-4C95-B0C7-4E2833462914@dslextreme.com> <1704306A-5B43-4CBA-8D11-D2D8C5D52BBB@dslextreme.com> To: Log4J Developers List In-Reply-To: X-Mailer: Apple Mail (2.2104) X-MAG-OUTBOUND: greymail.redcondor.net@137.118.22.64/27 --Apple-Mail=_1C5082BE-359E-460F-8739-3B25704AD97E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 That=E2=80=99s not are reason to redo a release candidate, especially = since I think that bug has been around a while. As a reminder, your vote means that you have downloaded and inspected = the release candidate and didn=E2=80=99t find any defects that are = showstoppers, both in terms of operation and packaging. So something = like a severe performance degradation, binary compatibility breakage, = missing license headers, artifacts that are improperly signed, etc are = all reasons to vote -1 on a release. Ralph > On Oct 11, 2015, at 4:11 PM, Matt Sicker wrote: >=20 > It's a rather minor change that would fix a bug marked critical, so it = could be worth redoing the RC. I'll make a vote on that. >=20 > On 11 October 2015 at 17:30, Ralph Goers > wrote: > Also, your vote is still binding so if you want to review and vote on = the release you can. That said, I understand if you want to take some = time and get acquainted with the code again. >=20 > Ralph >=20 >> On Oct 11, 2015, at 3:28 PM, Ralph Goers > wrote: >>=20 >> No nothing has really changed. I have a branch I am waiting to commit = to master since I don=E2=80=99t want it included if I have to create = another release candidate. That wouldn=E2=80=99t be a problem for simple = bug fixes. >>=20 >> Ralph >>=20 >>> On Oct 11, 2015, at 3:03 PM, Matt Sicker > wrote: >>>=20 >>> Has anything changed in regard to branching since I last = contributed? I pushed a commit to master to fix a bug, but I forgot to = make sure that was still the right way to do things (especially with an = RC going on). >>>=20 >>> --=20 >>> Matt Sicker > >>=20 >=20 >=20 >=20 >=20 > --=20 > Matt Sicker > --Apple-Mail=_1C5082BE-359E-460F-8739-3B25704AD97E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
That=E2=80=99s not are reason to redo a = release candidate, especially since I think that bug has been around a = while.

As a = reminder, your vote means that you have downloaded and inspected the = release candidate and didn=E2=80=99t find any defects that are = showstoppers, both in terms of operation and packaging. So something = like a severe performance degradation, binary compatibility breakage, = missing license headers, artifacts that are improperly signed, etc are = all reasons to vote -1 on a release.

Ralph


On Oct 11, 2015, at 4:11 PM, Matt Sicker = <boards@gmail.com> wrote:

It's a rather minor change that would fix a bug marked = critical, so it could be worth redoing the RC. I'll make a vote on = that.

On 11 October 2015 at 17:30, Ralph Goers <ralph.goers@dslextreme.com> = wrote:
Also, your = vote is still binding so if you want to review and vote on the release = you can. That said, I understand if you want to take some time and get = acquainted with the code again.

Ralph

On Oct 11, 2015, at 3:28 PM, Ralph Goers <ralph.goers@dslextreme.com> wrote:

No nothing has really changed. I have a = branch I am waiting to commit to master since I don=E2=80=99t want it = included if I have to create another release candidate. That wouldn=E2=80=99= t be a problem for simple bug fixes.

Ralph

On Oct = 11, 2015, at 3:03 PM, Matt Sicker <boards@gmail.com> wrote:

Has anything = changed in regard to branching since I last contributed? I pushed a = commit to master to fix a bug, but I forgot to make sure that was still = the right way to do things (especially with an RC going on).

--
Matt Sicker <boards@gmail.com>




--
Matt Sicker <boards@gmail.com>

= --Apple-Mail=_1C5082BE-359E-460F-8739-3B25704AD97E--