logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <ralph.go...@dslextreme.com>
Subject Re: Pattern layout and Markers
Date Fri, 02 Oct 2015 15:55:55 GMT
Mikael, we generally only create code branches when we have things that we would like feedback
on before we commit them to master. Frankly, I do my code reviews using the emails from git.
 At least 80% of Gary’s commits are just code “cleanups” so are easy to look at - he
is pretty good at separating those from actual code modifications. 

Ralph

> On Oct 2, 2015, at 7:08 AM, Mikael Ståldal <mikael.staldal@magine.com> wrote:
> 
> I think it will be easier to do code review if you make a branch in Git, rather than
uploading a diff.
> 
> On Fri, Oct 2, 2015 at 1:05 AM, Gary Gregory <garydgregory@gmail.com <mailto:garydgregory@gmail.com>>
wrote:
> Feedback please: https://issues.apache.org/jira/browse/LOG4J2-1146 <https://issues.apache.org/jira/browse/LOG4J2-1146>
> 
> Note the addition of the isVariable() method.
> 
> Gary
> 
> On Wed, Sep 30, 2015 at 7:45 PM, Ralph Goers <ralph.goers@dslextreme.com <mailto:ralph.goers@dslextreme.com>>
wrote:
> Topic 1
> 
> This is quite a common use case. I have no problem with %equals but %notEmpty{[%marker]}
would be nicer for this use case - it would mean don’t print anything if the variables in
the pattern are empty strings.
> 
> Ralph
> 
>> On Sep 30, 2015, at 5:15 PM, Gary Gregory <garydgregory@gmail.com <mailto:garydgregory@gmail.com>>
wrote:
>> 
>> Topic 1
>> 
>> Let's say I want my logs to look like this:
>> 
>> Date [thread] [loggerName] [MarkerName] Message
>> 
>> But most of the time I do not have a marker so I end up with a lot of lame looking
log entries with [].
>> 
>> Instead I'd rather see nothing. 
>> 
>> I could use a replace like this (not tested):
>> 
>> %replace{[%marker]}{\[\]}{}
>> 
>> But that seems 'expensive' and cryptic, the perfect combo ;-)
>> 
>> Should we had a gadget so you can configure like:
>> 
>> %equals{[%marker]}{[]}{}
>> 
>> Which just does a String.equals instead of a RE match?
>> 
>> Topic 2
>> 
>> The toString on Markers are not nice when the marker has parents. Therefore, I'd
like to add %simpleMarker (like there is a Class#getSimpleName). simpleMarker gets the name
sans parents.
>> 
>> Then I can say:
>> 
>> %equals{[%simpleMarker]}{[]}{}
>> 
>> Thoughts?
>> 
>> -- 
>> E-Mail: garydgregory@gmail.com <mailto:garydgregory@gmail.com> | ggregory@apache.org
 <mailto:ggregory@apache.org>
>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>

>> Home: http://garygregory.com/ <http://garygregory.com/>
>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com <mailto:garydgregory@gmail.com> | ggregory@apache.org
 <mailto:ggregory@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
> 
> 
> -- 
>  
> 
> Mikael Ståldal
> Senior software developer 
> 
> Magine TV
> mikael.staldal@magine.com <mailto:mikael.staldal@magine.com>    
> Regeringsgatan 25  | 111 53 Stockholm, Sweden  |   www.magine.com  <http://www.magine.com/>
> 
> Privileged and/or Confidential Information may be contained in this message. If you are
not the addressee indicated in this message
> (or responsible for delivery of the message to such a person), you may not copy or deliver
this message to anyone. In such case, 
> you should destroy this message and kindly notify the sender by reply email.   


Mime
View raw message