logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1142) ThreadLocals in Layout implementations should be non-static to prevent memory leaks in web containers
Date Wed, 30 Sep 2015 21:49:04 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938933#comment-14938933
] 

Ralph Goers commented on LOG4J2-1142:
-------------------------------------

Remko, Can you just create a pool in each PatternLayout and then have each call to toSerializable
remove it from the pool at the beginning and return it to the pool at the end of the method?
 That doesn't require any knowledge of threads.

> ThreadLocals in Layout implementations should be non-static to prevent memory leaks in
web containers
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1142
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1142
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Layouts
>    Affects Versions: 2.4
>            Reporter: Dmitri Blinov
>            Assignee: Remko Popma
>             Fix For: 2.4.1
>
>
> As discussed in LOG4J2-1125, storing ThreadLocal<StringBuilder> in a static field
may not interact well with the thread pools and class loaders of some web containers and may
result in memory leaks, especially in older web containers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message