logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields
Date Mon, 14 Sep 2015 15:49:46 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743700#comment-14743700
] 

Ralph Goers commented on LOG4J2-1121:
-------------------------------------

I am pretty sure the original solution I implemented had it all covered. I guess I wasn't
paying close enough attention to see how things changed since then.

> LoggerConfig performance improvement: remove waitForCompletion and associated fields
> ------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1121
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1121
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.3
>            Reporter: Remko Popma
>
> This ticket follows up on LOG4J2-1120. Out of the three changes identified in LOG4J2-1120,
only two could be implemented in time for the 2.4 release.
> This ticket tracks the remaining work for the third change:
> * Since {{clearAppenders()}} is only called after all appenders have been stopped, {{waitForCompletion()}}
may no longer be necessary (unless I am missing something here). If so, the {{shutdownLock}},
{{shutdown}} and {{counter}} fields can be removed. Not incrementing the atomic counters with
every event in the hot path should give better performance.
> LOG4J2-1120 shows benchmark results that support this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message