logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <ralph.go...@dslextreme.com>
Subject Re: Checkstyle
Date Sat, 12 Sep 2015 00:36:59 GMT
Actually, I am fine with setters that do that as well. Both can be configured to be OK with
the HiddenField element.

Ralph

> On Sep 11, 2015, at 5:22 PM, Gary Gregory <garydgregory@gmail.com> wrote:
> 
> Checkstyle complains about code like this:
> 
> private final int foo;
> Ctor(int foo) {
>   this.foo = foo;
> }
> 
> Which is perfectly acceptable IMO. 
> 
> I really do not see the point of renaming all param names in a ctor.
> 
> In a normal method, yes, you do not want to 'hide' an ivar with a pname.
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com <mailto:garydgregory@gmail.com> | ggregory@apache.org
 <mailto:ggregory@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>

Mime
View raw message