logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: logging-log4j2 git commit: Eat own fluent god food.
Date Tue, 01 Sep 2015 23:31:30 GMT
:-)

On Tue, Sep 1, 2015 at 4:28 PM, Remko Popma <remko.popma@gmail.com> wrote:

> Haha! Funny comment. :-)
>
> Sent from my iPhone
>
> > On 2015/09/02, at 6:50, ggregory@apache.org wrote:
> >
> > Repository: logging-log4j2
> > Updated Branches:
> >  refs/heads/LOG4J2-952 021f7d198 -> 821cd5ad8
> >
> >
> > Eat own fluent god food.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/821cd5ad
> > Tree:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/821cd5ad
> > Diff:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/821cd5ad
> >
> > Branch: refs/heads/LOG4J2-952
> > Commit: 821cd5ad84d81f55adec2b3c6b15c87e7d83170c
> > Parents: 021f7d1
> > Author: ggregory <ggregory@apache.org>
> > Authored: Tue Sep 1 14:50:13 2015 -0700
> > Committer: ggregory <ggregory@apache.org>
> > Committed: Tue Sep 1 14:50:13 2015 -0700
> >
> > ----------------------------------------------------------------------
> > .../config/builder/impl/DefaultAppenderComponentBuilder.java   | 6 ++----
> > .../builder/impl/DefaultAppenderRefComponentBuilder.java       | 3 +--
> > .../builder/impl/DefaultCompositeFilterComponentBuilder.java   | 3 +--
> > .../config/builder/impl/DefaultLoggerComponentBuilder.java     | 6 ++----
> > .../config/builder/impl/DefaultRootLoggerComponentBuilder.java | 6 ++----
> > 5 files changed, 8 insertions(+), 16 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/821cd5ad/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
> > ----------------------------------------------------------------------
> > diff --git
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
> > index 10c5d51..cdaeb96 100644
> > ---
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
> > +++
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
> > @@ -34,13 +34,11 @@ class DefaultAppenderComponentBuilder extends
> DefaultComponentAndConfigurationBu
> >
> >     @Override
> >     public AppenderComponentBuilder add(LayoutComponentBuilder builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> >
> >     @Override
> >     public AppenderComponentBuilder add(FilterComponentBuilder builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> > }
> >
> >
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/821cd5ad/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
> > ----------------------------------------------------------------------
> > diff --git
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
> > index 19f7b17..7ee5f0f 100644
> > ---
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
> > +++
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
> > @@ -35,7 +35,6 @@ class DefaultAppenderRefComponentBuilder extends
> DefaultComponentAndConfiguratio
> >
> >     @Override
> >     public AppenderRefComponentBuilder add(FilterComponentBuilder
> builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> > }
> >
> >
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/821cd5ad/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
> > ----------------------------------------------------------------------
> > diff --git
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
> > index 95d17f3..b9bb80d 100644
> > ---
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
> > +++
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
> > @@ -36,8 +36,7 @@ class DefaultCompositeFilterComponentBuilder
> >
> >     @Override
> >     public CompositeFilterComponentBuilder add(FilterComponentBuilder
> builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> >
> > }
> >
> >
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/821cd5ad/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
> > ----------------------------------------------------------------------
> > diff --git
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
> > index 7c5f4dc..f72c76a 100644
> > ---
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
> > +++
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
> > @@ -54,13 +54,11 @@ class DefaultLoggerComponentBuilder extends
> DefaultComponentAndConfigurationBuil
> >
> >     @Override
> >     public LoggerComponentBuilder add(AppenderRefComponentBuilder
> builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> >
> >     @Override
> >     public LoggerComponentBuilder add(FilterComponentBuilder builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> > }
> > \ No newline at end of file
> >
> >
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/821cd5ad/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
> > ----------------------------------------------------------------------
> > diff --git
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
> > index 19f84c5..be266df 100644
> > ---
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
> > +++
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
> > @@ -52,14 +52,12 @@ class DefaultRootLoggerComponentBuilder extends
> DefaultComponentAndConfiguration
> >
> >     @Override
> >     public RootLoggerComponentBuilder add(AppenderRefComponentBuilder
> builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> >
> >
> >     @Override
> >     public RootLoggerComponentBuilder add(FilterComponentBuilder
> builder) {
> > -        addComponent(builder);
> > -        return this;
> > +        return addComponent(builder);
> >     }
> > }
> > \ No newline at end of file
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message