logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <ralph.go...@dslextreme.com>
Subject Re: logging-log4j2 git commit: Reset sys prop at the end of the test. Use specific static imports instead of *.
Date Wed, 02 Sep 2015 04:28:03 GMT
Wildcard static imports are encouraged. That doesn’t mean required.

Ralph

> On Sep 1, 2015, at 5:32 PM, Gary Gregory <garydgregory@gmail.com> wrote:
> 
> I see. Well,we do not seem to follow that style consistently :-( I see 105 static imports
that are not *.
> 
> Gary
> 
> On Tue, Sep 1, 2015 at 4:50 PM, Remko Popma <remko.popma@gmail.com <mailto:remko.popma@gmail.com>>
wrote:
> C'mon, we agreed on this!
> 
> From our style guide:
> No wildcard imports in the main tree
> 
> Wildcard imports, static or otherwise, are not used.
> 
>  <>Static wildcard imports in the test tree
> 
> Wildcard static imports are encouraged for test imports like JUnit, EasyMock, and Hamcrest.
> 
> 
> Sent from my iPhone
> 
> On 2015/09/02, at 8:05, Gary Gregory <garydgregory@gmail.com <mailto:garydgregory@gmail.com>>
wrote:
> 
>> Gross. If you have more than one * you have no idea where stuff comes from.
>> 
>> Gary
>> 
>> On Tue, Sep 1, 2015 at 4:02 PM, Remko Popma <remko.popma@gmail.com <mailto:remko.popma@gmail.com>>
wrote:
>> The explicit static imports is not an improvement.
>> 
>> I much prefer
>> import static org.junit.Assert.*;
>> 
>> 
>> Sent from my iPhone
>> 
>> > On 2015/09/02, at 7:04, ggregory@apache.org <mailto:ggregory@apache.org>
wrote:
>> >
>> > import static org.junit.Assert.*;
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org <mailto:log4j-dev-unsubscribe@logging.apache.org>
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org <mailto:log4j-dev-help@logging.apache.org>
>> 
>> 
>> 
>> 
>> -- 
>> E-Mail: garydgregory@gmail.com <mailto:garydgregory@gmail.com> | ggregory@apache.org
 <mailto:ggregory@apache.org>
>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>

>> Home: http://garygregory.com/ <http://garygregory.com/>
>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com <mailto:garydgregory@gmail.com> | ggregory@apache.org
 <mailto:ggregory@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>

Mime
View raw message